fix deprecated pickCamera #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@esafirm Please help me review it |
|
Hey @chihung93 this looks good except for the nitty formatting. Could you please take a look? Thanks. |
esafirm
force-pushed
the
issue/remove_depreacted_camera
branch
from
694d662
to
d132e7e
Compare
|
It's all good. Already push the formatting commit myself and merge the PR
…On Mon, Oct 24, 2022, 10:44 Henry ***@***.***> wrote:
Hi @esafirm <https://github.com/esafirm> , What do you mean the nitty
formatting?
I assume that its a reformatted code, so I have do that on this PR #417
<#417>
Thanks.
—
Reply to this email directly, view it on GitHub
<#408 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM46MEIQFAZEFKDMU6AMDDWEYA2JANCNFSM6AAAAAARF5PDAM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed onActivityResult which is deprecated