New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
new and simpler build workflow #481
Conversation
wow you are fast 馃槃 |
Just realized: Do we break Bower if we remove |
could be. It's a long time since I last used bower 馃槅 |
Yeah. I haven't ever used it or personally know anybody using it. |
I guess we need to add it to support bower. |
Meteor might require it too. Component seems to be dead https://github.com/componentjs/component#this-project-is-deprecated |
I added |
Sorry. Will have to sleep now. |
@splendido do you know if meteor needs the build artefacts in the repo? |
@stoeffel what do you mean with 'build artefacts'? |
@splendido by build-artefacts I mean every thing in the |
I see. But if you could publish by hands you'd only need that file when running |
Okay. Thanks for your help. I think we should just keep the dist in the repo. Makes it easier to support meteor and bower needs it anyway. |
I will merge on Monday and will release a new version (and include some bug fix PRs.) |
1a3d34c
to
df0903a
Compare
Will do a last review this afternoon or tomorrow and then merge and publish a patch release. // cc @epeli any objections? |
@stoeffel Are you still planning to publish a patch release soon? |
* move eslint to package.json * adds coverage script * adds build and release scripts * remove gulp * update build instructions * create and push a tag * update eslintignore * publish to npm last * fixes npmcdn links * omit version tag to always use the latest.
df0903a
to
7e4efd4
Compare
Totally, sorry for the delay. I had to take care of my baby daughter today. I will definitely work on it tomorrow. |
No problem-- just curious about the timeframe. Thanks for the information! |
new and simpler build workflow
This removes gulp completely. I will do the same for the gh-pages branch if you like.
As you can see to release we just need to update the changelog and the version in the package.json and then run
npm run release
.This will allow use to have a much shorter release cycle (it's a pain atm to publish a new version).
It also removes the build artefacts from the repo and links to npmcdn.
The built artefacts are directly in the root of the module (after publishing).
And it removes some eslint issues 馃樃
closes #478
I will have to check this again tomorrow, have to sleep first.
@epeli would be cool if you could review this.