Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

new and simpler build workflow #481

Merged
merged 1 commit into from Feb 24, 2016
Merged

new and simpler build workflow #481

merged 1 commit into from Feb 24, 2016

Conversation

stoeffel
Copy link
Collaborator

This removes gulp completely. I will do the same for the gh-pages branch if you like.
As you can see to release we just need to update the changelog and the version in the package.json and then run npm run release.
This will allow use to have a much shorter release cycle (it's a pain atm to publish a new version).

It also removes the build artefacts from the repo and links to npmcdn.
The built artefacts are directly in the root of the module (after publishing).
And it removes some eslint issues 馃樃
closes #478

I will have to check this again tomorrow, have to sleep first.
@epeli would be cool if you could review this.

@stoeffel
Copy link
Collaborator Author

wow you are fast 馃槃

@esamattis
Copy link
Owner

Just realized: Do we break Bower if we remove dist?

@stoeffel
Copy link
Collaborator Author

Just realized: Do we break Bower if we remove dist?

could be. It's a long time since I last used bower 馃槅

@esamattis
Copy link
Owner

Yeah. I haven't ever used it or personally know anybody using it.

@stoeffel
Copy link
Collaborator Author

I guess we need to add it to support bower.

@esamattis
Copy link
Owner

Meteor might require it too. Component seems to be dead https://github.com/componentjs/component#this-project-is-deprecated

@stoeffel
Copy link
Collaborator Author

I added dist again
and a new task build:clean

@stoeffel
Copy link
Collaborator Author

Sorry. Will have to sleep now.
Feel free to commit and change every thing.

@stoeffel
Copy link
Collaborator Author

@splendido do you know if meteor needs the build artefacts in the repo?

@stoeffel
Copy link
Collaborator Author

@epeli any input on this and #482. I think we have to keep dist in the repo for now.

@splendido
Copy link
Contributor

@stoeffel what do you mean with 'build artefacts'?
...any file created by 'meteor publish' can be safely removed

@stoeffel
Copy link
Collaborator Author

@splendido by build-artefacts I mean every thing in the dist folder.

@splendido
Copy link
Contributor

I see.
Well, if you like to continue with autopublish the answer is yes: at the time of running meteor publish the file dist/underscore.string.js must be there (see this line).

But if you could publish by hands you'd only need that file when running meteor publish which means you could build the project, publish it for Meteor and then clean up everything.

@stoeffel
Copy link
Collaborator Author

Okay. Thanks for your help. I think we should just keep the dist in the repo. Makes it easier to support meteor and bower needs it anyway.

@stoeffel
Copy link
Collaborator Author

stoeffel commented Feb 8, 2016

@epeli. I think this and #482 is good to go. Do you have some time this week or next to review. I think this will speed up our release cycle. Currently it's a bit of a pain.

@stoeffel stoeffel mentioned this pull request Feb 19, 2016
@stoeffel
Copy link
Collaborator Author

I will merge on Monday and will release a new version (and include some bug fix PRs.)

@cahrens cahrens mentioned this pull request Feb 20, 2016
@stoeffel stoeffel force-pushed the new-build-chain branch 3 times, most recently from 1a3d34c to df0903a Compare February 22, 2016 08:30
@stoeffel
Copy link
Collaborator Author

rebased and squashed

Will do a last review this afternoon or tomorrow and then merge and publish a patch release.

// cc @epeli any objections?

@cahrens
Copy link
Contributor

cahrens commented Feb 23, 2016

@stoeffel Are you still planning to publish a patch release soon?

* move eslint to package.json
* adds coverage script
* adds build and release scripts
* remove gulp
* update build instructions
* create and push a tag
* update eslintignore
* publish to npm last
* fixes npmcdn links
* omit version tag to always use the latest.
@stoeffel
Copy link
Collaborator Author

@stoeffel Are you still planning to publish a patch release soon?

Totally, sorry for the delay. I had to take care of my baby daughter today. I will definitely work on it tomorrow.
The new build chain should allow us to publish faster.

@cahrens
Copy link
Contributor

cahrens commented Feb 23, 2016

No problem-- just curious about the timeframe. Thanks for the information!

stoeffel added a commit that referenced this pull request Feb 24, 2016
new and simpler build workflow
@stoeffel stoeffel merged commit a6d40ec into master Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use npmcdn.com instead of commiting build artifacts into git
4 participants