feat: support transform imports #256
Closed
+92
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What for? Also:
|
ghost
mentioned this pull request
|
We also need this feature, is it possible to continue the work? |
|
@chengjiaapraamcos Unfortunately, I deleted the code. My code is based on regex analysis, which is not allowed by this repo. |
|
In general, opening a PR without an explanation will never get approved. Based on #260, this feature is irrelevant to esbuild and doesn't make sense to be in this project. Although it's out of scope, I encourage you to make your own Webpack loader with it and just chain it in your configuration. BTW, your code isn't deleted. It's still viewable in this PR. But yeah, regex is not reliable. You should use es-module-lexer instead. |
Repository owner
locked as off-topic and limited conversation to collaborators
Jun 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support transform imports like
babel-plugin-transform-importsdoes