This repository has been archived by the owner on Oct 18, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: cts no longer transformed
privatenumber
changed the title
fix: ignore ts in cjs contexts
fix: skip transforming CommonJS files
May 17, 2022
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Node.js is unable to detect whether a
.ts
file iscommonjs
/module
, and assumes all.ts
files aremodule
. This fails when there are TS files that expect to be executed in a CJS context (eg. using__dirname
/__filename
).This loader should not transform
.cts
files to ESM because it's technically a CJS file (withimport
/export
syntax support). It should be able to access__filename
, and therefore, must be delegated to the cjs-loader.closes privatenumber/tsx#2
Changes
commonjs
, lettingcjs-loader
handle transforming TS files incommonjs
contexts.__esModule
.