Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picker handleEditingChanged too early #540

Closed
jorisroling opened this issue Aug 5, 2013 · 2 comments
Closed

Picker handleEditingChanged too early #540

jorisroling opened this issue Aug 5, 2013 · 2 comments

Comments

@jorisroling
Copy link

Hi Escoz,

In QPickerTableViewCell.m in the function pickerView:didSelectRow:
should the call to [self.pickerElement handleEditingChanged] not be AFTER the value has changed?
That way I can see the changes in my changeHandler, like with the other EntryElements.

Regards,
Joris (fan of QuickDialog)

@bartvandendriessche
Copy link
Contributor

I've run into this issue in the past.

I worked around it by using KVO on the picker's value property.

Ideally, there should either be 2 handlers (willChange and didChange) or a single handler that passes in both the old and the new value.

@escoz
Copy link
Owner

escoz commented Sep 11, 2013

Changed it, thanks.

@escoz escoz closed this as completed Sep 11, 2013
bartvandendriessche pushed a commit to bartvandendriessche/QuickDialog that referenced this issue Nov 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants