refactor: support gnome 45 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- convert imports across codebase to be compatible with gnome 45 - specify export default for SpTrayExtension class - update shell-version in metadata.json to only support v45 - increment version from v21 to v22 in metadata.json - change var keyword to const across the codebase
mcmxcdev
commented
Oct 1, 2023
| "43", | ||
| "44" | ||
| ], | ||
| "shell-version": ["45"], |
There was a problem hiding this comment.
Note that all the previous versions were dropped. The docs mention explicitely that v45 is not compatible with older versions due to the changed imports syntax.
See more: https://release.gnome.org/45/developers/index.html
|
Yeah I've been kinda busy with a bunch of other things so I couldn't find the time to deal with gnome 45 stuff. Thank you for this. Not sure how the notifications work there, but I've changed this PR's target to a new branch. I'll merge it later into master after having gone through it myself and maybe played with it a little. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Description
It would be great for potential contributors if there was a
CONTRIBUTING.mdfile detailing the steps necessary to be able to contribute properly. I was blindly following along the guide at https://gjs.guide/extensions/upgrading/gnome-shell-45.html#esm but wasn't able to test anything out, etcMy intention was to at least kick this off an then hand it over to you @esenliyim 😃
Closes #42