Initial pass at a queue for locks #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| it 'does not unlock a label when someone else locked it' do | ||
| send_command('locker resource create foobar') | ||
| send_command('locker label create bazbat') | ||
| send_command('locker label add foobar to bazbat') | ||
| send_command('lock bazbat', as: alice) | ||
| send_command('unlock bazbat', as: bob) | ||
| expect(replies.last).to eq('(failed) bazbat is locked by Alice (@alice)') | ||
| expect(replies.last).to eq('(failed) bazbat is locked by Alice (@alice), you have been added ' \ | ||
| 'to the queue, type \'locker dequeue bazbat\' to be removed') |
There was a problem hiding this comment.
This messaging seems odd: bob attempting to unlock a label he doesn't own shouldn't add him to the queue.
|
@dougbarth Updated based on feedback, yeah the unlock was a weird case that should have been the other way. |
esigler
added a commit
that referenced
this pull request
Jan 9, 2015
Initial pass at a queue for locks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we go!