Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't make natively maximised windows *always on top* #124

Merged
merged 1 commit into from
Dec 28, 2020

Conversation

abrac
Copy link
Contributor

@abrac abrac commented Nov 9, 2020

All I did was implement the changes you recommended here and here. I'm not sure why the default behaviour is to make natively maximised windows always on top. I'm not familiar with your codebase, so please discard this pull request if you think it might cause problems.

@v3ss0n
Copy link

v3ss0n commented Nov 22, 2020

They need to be ontop since they are natively maximised and users may need it to be ontop.

@magiruuvelvet
Copy link

@v3ss0n Well I disagree, maximized windows may be tiled and should be on bottom so floating windows on top aren't disappearing when the maximized window gains focus. Specially annoying when you use mouse focus behavior rather than click focus behavior in KDE.

@v3ss0n
Copy link

v3ss0n commented Nov 22, 2020

I use click focus behavior , may be thats why its fine for me.

@abrac
Copy link
Contributor Author

abrac commented Nov 22, 2020

They need to be ontop since they are natively maximised and users may need it to be ontop.

@v3ss0n I agree that windows should be on top when you maximise them, but the problem is that they are always on top (i.e. kept above other windows). That is, even if you switch to another window, the one that you maximised will be on top of it.

Suppose you have three windows open in a tiled layout. If I maximise one of the windows I expect it to be on top, but I want it go lower when I switch to another window.

@v3ss0n
Copy link

v3ss0n commented Nov 23, 2020 via email

@esjeon esjeon merged commit 2a47753 into esjeon:master Dec 28, 2020
@v3ss0n
Copy link

v3ss0n commented Jan 1, 2021

awesome~ should this make a newyear release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants