Extracted resolution to classes and added some unit-tests #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,12 +26,19 @@ | |||
| </license> | |||
| </licenses> | |||
|
|
|||
| <inceptionYear>2012</inceptionYear> | |||
|
Hello Mirko, Theses changes look fine to me. I'm glad you found this plugin helpful enough to get motivated for contributing code! /Paul |
|
I will fix this in the evening, during the day my kids want to play :-) Regards Mirko |
eskatos
added a commit
that referenced
this pull request
Nov 2, 2012
Extracted resolution to classes and added some unit-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Paul,
I extracted the package and classname resolution to classes and added some unit-tests. Later-on I plan to add more intelligence to the resolution, e.g. when the package groupId.artifactId exists, put the ArtifactInfo class into this package.
Regards
Mirko