Fix crash when geocoder exceeds Google Maps API usage limits #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eskerda Oh, it looks like we've been fixing it at the same time and you were slightly faster 👅 |
PabloCastellano
force-pushed
the
master
branch
from
dd59c46
to
e9cc4d7
Compare
|
Damn! @PabloCastellano thanks, I should have waited. It's good that we went with a similar approach. Since you are using it, feel free to add any feature you might need on cmdbikes! I released it as a kind of in-joke, but I am glad it is useful. Maybe geocoding by IP makes sense. Also, there's no --version flag, and help also does not display the version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't investigated further, but it happens probably due to the recent changes in Google Maps API and their usage limits. Possibly related: DenisCarriere/geocoder#375
As a workaround, default to OSM in case of error which doesn't require an API key.