Allocate reserved relay address #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not possible to start a worker from outside the dispatcher without the receiver's client socket. Since client_info is already passed around, it's the logical place to add the socket to. This way we're gonna be able to start a worker inside the allocate request handler code.
client_info.port is port on which we receive datagrams from the client. Therefore, we can't use this client_info instance to create a reserved worker for the new allocation, as the client will connect from different port. We have to rely on dispatcher to create the new worker process, but at the same time store the reservation somewhere, so that it can be picked up by that new worker when it reads the RESERVATION-TOKEN attribute coming with an allocate request.
This dramatically reduces the overhead (approx. 3x less space consumed per reservation).
Until now the log was tied to the server's listening port. This does not work well with the test helpers we have in place, and is not conformant with the RFC: > [the client] can use a different client IP address and > port, a different transport protocol, and even different server IP > address and port [when requesting an allocation with a RESERVATION-TOKEN]
arkgil
approved these changes
Apr 28, 2017
| Logger.warn(:max_retries) | ||
| {:error, ErrorCode.new(:insufficient_capacity)} | ||
| end | ||
| defp open_this_relay( params, state, server) do |
There was a problem hiding this comment.
There is a space before first param.
There was a problem hiding this comment.
Right. It looked better when the signature was:
defp open_this_relay(_params, %{retries: r}, _server) when r < 0, do: ...
defp open_this_relay( params, state, server) do ...
lib/fennec/turn/reservation.ex
Outdated
| socket: socket} | ||
| end | ||
|
|
||
| @doc false |
There was a problem hiding this comment.
There is no need for @doc false if there is @moduledoc false.
|
Can we merge this and work on reservation expiration as a separate issue? I wouldn't want to rebase this if anything unexpected happens on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might still need some polish / refactoring, but the happy path finally works, i.e. full support for EVEN-PORT and RESERVATION-TOKEN (both issuing by the server to mark a newly created reservation and consuming when sent by a client, to use a previously reserved port).
Open TODOs (only reservation expiration is crucial feature-wise):
This addresses #22, #23.