Add support for Elixir 1.8 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rslota
force-pushed
the
rs/update_distillery
branch
from
44ba510
to
0979ba4
Compare
rslota
commented
Jun 19, 2019
| with_mock: 3, | ||
| with_mocks: 2 | ||
| ] | ||
| import Mock |
There was a problem hiding this comment.
There are some magic functions required by Mock to be imported while using Mock.with_mock. This means, that the "suggestion" from Mock documentation to import Mock is actually a requirement.
rslota
force-pushed
the
rs/update_distillery
branch
from
0979ba4
to
65e9958
Compare
rslota
changed the title
rslota
changed the title
rslota
force-pushed
the
rs/update_distillery
branch
3 times, most recently
from
468f6e6
to
c2dd531
Compare
rslota
force-pushed
the
rs/update_distillery
branch
from
c2dd531
to
a96814a
Compare
|
@rslota I suggest adding a support for Elixir 1.9 in one go 😉 |
This commit adds support for Elixir 1.9 by: * Upgrading Distillery to 2.0 * Upgrading other, less relevant dependencies that won't compile on Elixir 1.8/1.9 or generate lots of "deprecated" warnings * Small code changes to fix warnings generated by newer versions of Elixir * Minimal Elixir version of project has changed to 1.6, as it's not possible to make everything compile with a range of Elixir 1.4 - 1.9 * Elixir 1.8, 1.9 / Erlang 22.0 added to CI build matrix
rslota
force-pushed
the
rs/update_distillery
branch
from
c828054
to
2d13a9e
Compare
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for Elixir 1.8 by:
Elixir 1.8 or generate lots of "deprecated" warnings
Elixir
possible to make everything compile with a range of Elixir 1.4 - 1.8