The second release of mod_mam #151

arcusfelis · 2014-02-10T15:08:49Z

Changelog:

Add mod_mam_con_ca_arch and mod_mam_muc_ca_arch;
Fix error handling;
Add hook filter_local_packet;
Add mim_process_type into process dictionary

Tests are here

…berd_users_muc.localhost',{<<alicesroom>>,<<muc.localhost>>}],[]} during sending a MUC message.

Added an empty stop_server function.

…l ones.

…ined.

…reconnecting again. Added supervisor2.

…rlang.

Special entries were added into process dictionary: * mim_host - host of the process; * mim_process_type - category of the process. These tags can be used for debugging, better introspection and logging. Entries should not be used in business logic and/or from inside of the process.

arcusfelis · 2014-03-04T09:32:31Z

apps/mysql/src/mysql_conn.erl

@@ -272,6 +272,8 @@ do_recv(LogFun, RecvPid, SeqNum) when is_function(LogFun); LogFun == undefined,
 %% Returns : void() | does not return
 %%--------------------------------------------------------------------
 init(Host, Port, User, Password, Database, LogFun, Parent) ->
+    put(mim_host, Host),


Host is not a MongooseIM host, but MySQL server's IP.

michalwski · 2014-04-02T07:39:59Z

There is a lot of mod_mam_* files right now. What do you think of moving them do a dedicated subdirectory? Or maybe even other repo which will be a dependency for MongooseIM?

Fixed specs Conflicts: apps/ejabberd/src/mod_mam.erl apps/ejabberd/src/mod_mam_cache_user.erl apps/ejabberd/src/mod_mam_muc.erl apps/ejabberd/src/mod_mam_muc_odbc_arch.erl apps/ejabberd/src/mod_mam_odbc_arch.erl apps/ejabberd/src/mod_mam_utils.erl rebar.config rel/reltool.config

While Base 36 is slightly shorter, Base 32 is easy to read

michalwski · 2014-05-30T10:31:04Z

@arcusfelis, could you rebase or merge with master?
And what do you think about my prev comment (regarding moving mod_mam_* file to dedicated subdirectory)?

arcusfelis · 2014-05-31T17:25:12Z

Fine, I will rebase or merge.
I do not like the idea of changing file names, because it makes working with git history harder.

michalwski · 2014-06-02T06:24:10Z

I do not like the idea of changing file names, because it makes working with git history harder.

Git is one thing, but clean code is another thing. Let's put that on vote. Could everyone involved in the project say wether it is good idea to move all mod_mam_* module to dedicated subdirectory or is it better to keep them as is?

michalwski · 2014-06-02T06:24:48Z

And here goes my vote:
👍 for dedicated directory

fenek · 2014-06-02T06:49:56Z

👍 for dedicated directory, also 👍 for dedicated directory for mod_admin_extra_*.erl - it also has many files.

pzel · 2014-06-03T07:45:08Z

☝︎ for dedicated dir. Also, it might make sense to move the larger modules into their own apps/mod* directories. (This is a separate topic, but please think about it)

erszcz · 2014-06-03T08:55:23Z

I hold from voting, but would like to pinpoint that introducing extra dirs per module is repeating history. In pre-fork ejabberd there were actually multiple directories below src/ (e.g. odbc, web, pubsub). One of the steps performed when making MongooseIM (then just esl-ejabberd) OTP/Rebar compliant was flattening that layout.
Is introducing subdirs to src/ even compliant with Rebar?

pzel · 2014-06-03T09:07:52Z

@Lavrin: and the apps/your_module_here approach? Would it help here?

michalwski · 2014-06-03T10:46:58Z

Is introducing subdirs to src/ even compliant with Rebar?

Yes, it is.

Also, it might make sense to move the larger modules into their own apps/mod* directories. (This is a separate topic, but please think about it)

I think that's better solution. This approach has additional advantage - we can easily add/remove such app from Erlang release making the final release smaller if given big functionality is not required. Good candidates for that are mod_mam and, as @fenek noticed, mod_admin_extra.

The second release of mod_mam

arcusfelis added 30 commits January 10, 2014 03:26

Added a first version of Cassandra MAM backend.

98c0dcb

Added query_refs_count for mod_mam_muc_ca_arch.

1b34361

Added new book filter_local_packet. Fixed {badarg,[{ets,member,['ejab…

4f52139

…berd_users_muc.localhost',{<<alicesroom>>,<<muc.localhost>>}],[]} during sending a MUC message.

Added a special version of mod_mam_cache_user for MUC.

1f862da

Added an empty stop_server function.

Added mod_mam_odbc_server_user: archive id assignor for multiple hosts.

5f57392

Added unique constraint for mam_user and mam_server_user tables.

7e9dcef

Deleted MAM_ARCHIVE_PRESENCE. Splited is_complete_message into severa…

96a6787

…l ones.

Added seestar into release dependencies.

a4963f8

Fixed wrong function name.

6fdb71c

Added prepare_user_id/1 for mod_mam_ca_arch.

5277e01

Added mod_mam_muc_ca_arch:select_worker/2.

8e95418

Merge branch 'arc-mam-mods' into arc-mam-ca

c0b0197

Added mod_mam_muc_ca_arch:prepare_room_id/1.

a429296

Added servers config variable for mod_mam_muc_ca_arch.

d682fa3

Select worker based on archive id in mod_mam_muc_ca_arch.

cffc459

Deleted prepare_room_id.

de799c0

Added mod_mam_con_ca_arch.

3ae3e19

Added mam_con_user table. for tracking conversations.

ccf9f3e

Removing messages from mod_mam_con_ca_arch.

ee5dfb4

Choosed a better strategy of cleaning conversation archives.

c87b188

Deleted mod_mam:check_archive_id/2 to allow an archive id to be undef…

de38339

…ined.

Added cassandra.cql.

bd8d543

Unreachable cassandra nodes do not crash MIM. Wait 10 seconds before …

fc27f26

…reconnecting again. Added supervisor2.

Added a helper function mod_mam_con_ca_arch:get_conversations_after/3.

0c1f48f

Allow filtering of the small result set on the server side.

568ba88

Filter data inside mod_mam_con_ca_arch:get_conversations_after/3 in E…

8947831

…rlang.

Added get_last_conversations/2.

e09d327

Replaced mam_ns_binary() with ?NS_MAM.

1c22f7e

Handle timeouts (show an error message and increase metric's value).

95ac562

Catch exceptions inside backend modules.

752eb4b

arcusfelis added 5 commits February 10, 2014 11:25

Deleted incompleted mod_mam_ca_arch.

d779e83

Added configuration examples for Cassandra back-ends.

32bf411

Merge branch 'arc-mam-mods' into arc-mam-rel2

a3265b3

Merge branch 'arc-mam-ca' into arc-mam-rel2

e36db07

arcusfelis reviewed Mar 4, 2014
View reviewed changes

arcusfelis added 4 commits May 29, 2014 15:55

Encode MAM message ids in Base 32

08813f4

While Base 36 is slightly shorter, Base 32 is easy to read

Fix a bug in elem_to_end_microseconds/1

9223cec

Add PgSQL schema for mam_server_user table (compare with mysql.sql)

44d919f

michalwski mentioned this pull request May 30, 2014

Fix fetching mod_mam query <end> element value #206

Closed

michalwski added a commit that referenced this pull request Jun 4, 2014

Merge pull request #151 from arcusfelis/arc-mam-rel2

b4c7930

The second release of mod_mam

michalwski merged commit b4c7930 into esl:master Jun 4, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The second release of mod_mam #151

The second release of mod_mam #151

arcusfelis commented Feb 10, 2014

arcusfelis Mar 4, 2014

michalwski commented Apr 2, 2014

michalwski commented May 30, 2014

arcusfelis commented May 31, 2014

michalwski commented Jun 2, 2014

michalwski commented Jun 2, 2014

fenek commented Jun 2, 2014

pzel commented Jun 3, 2014

erszcz commented Jun 3, 2014

pzel commented Jun 3, 2014

michalwski commented Jun 3, 2014

The second release of mod_mam #151

The second release of mod_mam #151

Conversation

arcusfelis commented Feb 10, 2014

arcusfelis Mar 4, 2014

Choose a reason for hiding this comment

michalwski commented Apr 2, 2014

michalwski commented May 30, 2014

arcusfelis commented May 31, 2014

michalwski commented Jun 2, 2014

michalwski commented Jun 2, 2014

fenek commented Jun 2, 2014

pzel commented Jun 3, 2014

erszcz commented Jun 3, 2014

pzel commented Jun 3, 2014

michalwski commented Jun 3, 2014