Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable metrics_register_SUITE for dynamic domains #3275

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

Premwoik
Copy link
Contributor

Enable metrics_register_SUITE for dynamic domains

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #3275 (ded53bd) into master (69cc6b9) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3275      +/-   ##
==========================================
+ Coverage   80.19%   80.23%   +0.04%     
==========================================
  Files         398      398              
  Lines       32560    32560              
==========================================
+ Hits        26110    26125      +15     
+ Misses       6450     6435      -15     
Impacted Files Coverage Δ
src/pubsub/mod_pubsub_db_mnesia.erl 92.43% <0.00%> (-0.43%) ⬇️
src/ejabberd_sm.erl 84.26% <0.00%> (-0.33%) ⬇️
src/mod_muc_log.erl 77.88% <0.00%> (ø)
src/mod_roster.erl 79.41% <0.00%> (+0.24%) ⬆️
src/global_distrib/mod_global_distrib_receiver.erl 80.00% <0.00%> (+1.11%) ⬆️
src/mod_bosh_socket.erl 78.88% <0.00%> (+1.24%) ⬆️
src/mod_bosh.erl 93.87% <0.00%> (+2.04%) ⬆️
...c/global_distrib/mod_global_distrib_server_mgr.erl 76.83% <0.00%> (+2.25%) ⬆️
src/event_pusher/mod_event_pusher_sns.erl 89.47% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69cc6b9...ded53bd. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 16, 2021

small_tests_24 / small_tests / ded53bd
Reports root / small


internal_mnesia_24 / internal_mnesia / ded53bd
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 290 / Auto-skipped: 0


small_tests_22 / small_tests / ded53bd
Reports root / small


small_tests_23 / small_tests / ded53bd
Reports root / small


dynamic_domains_23 / pgsql_mnesia / ded53bd
Reports root/ big
OK: 2386 / Failed: 0 / User-skipped: 131 / Auto-skipped: 0


dynamic_domains_24 / pgsql_mnesia / ded53bd
Reports root/ big
OK: 2386 / Failed: 0 / User-skipped: 131 / Auto-skipped: 0


ldap_mnesia_22 / ldap_mnesia / ded53bd
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / ded53bd
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / ded53bd
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0


pgsql_mnesia_22 / pgsql_mnesia / ded53bd
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / ded53bd
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 316 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / ded53bd
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / ded53bd
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / ded53bd
Reports root/ big
OK: 3063 / Failed: 1 / User-skipped: 211 / Auto-skipped: 0

inbox_SUITE:muclight:non_reset_marker_should_not_affect_muclight_inbox
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_non_reset_marker_should_not_affect_muclight_inbox_85.608910@localhost/res1">>,
          escalus_tcp,<0.18365.0>,
          [{event_manager,<0.18359.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_non_reset_marker_should_not_affect_muclight_inbox_85.608910">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.18359.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_non_reset_marker_should_not_affect_muclight_inbox_85.608910">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_non_reset_marker_should_not_affect_muclight_inbox_85.608910">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_non_reset_marker_should_not_affect_muclight_inbox_85.608910">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"fa67408a585f7a1b">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,mark_last_muclight_system_message,3,
       [{file,"/home/circleci/app/big_test...

Report log


mysql_redis_24 / mysql_redis / ded53bd
Reports root/ big
OK: 3053 / Failed: 1 / User-skipped: 228 / Auto-skipped: 0

mam_SUITE:rdbms_simple_prefs_cases:messages_filtered_when_prefs_default_policy_is_roster
{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}

Report log


riak_mnesia_24 / riak_mnesia / ded53bd
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 319 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / ded53bd
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

@Premwoik Premwoik marked this pull request as ready for review September 16, 2021 12:49
@vkatsuba vkatsuba merged commit 0117dfa into master Sep 16, 2021
@vkatsuba vkatsuba deleted the dynamic_domains_metric_register_tests branch September 16, 2021 12:52
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but in init_per_testcase there is code which checks config per domain, not per host type:

XMPPDomain = ct:get_config({hosts, mim, domain}), case rpc(mim(), ejabberd_config, get_local_option, [{auth_method, XMPPDomain}]) of

It does not affect the results because currently we are not using external or anonymous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants