Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use host_type instead of domain in metrics_register_SUITE #3285

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

Premwoik
Copy link
Contributor

Related to this PR and adds the suggestions from Paweł to use host_type instead of domain.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 17, 2021

small_tests_24 / small_tests / aa9fc85
Reports root / small


internal_mnesia_24 / internal_mnesia / aa9fc85
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 290 / Auto-skipped: 0


small_tests_22 / small_tests / aa9fc85
Reports root / small


small_tests_23 / small_tests / aa9fc85
Reports root / small


dynamic_domains_24 / pgsql_mnesia / aa9fc85
Reports root/ big
OK: 2507 / Failed: 0 / User-skipped: 147 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / aa9fc85
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0


dynamic_domains_23 / pgsql_mnesia / aa9fc85
Reports root/ big
OK: 2507 / Failed: 0 / User-skipped: 147 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / aa9fc85
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0


ldap_mnesia_22 / ldap_mnesia / aa9fc85
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / aa9fc85
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


pgsql_mnesia_22 / pgsql_mnesia / aa9fc85
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / aa9fc85
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 316 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / aa9fc85
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / aa9fc85
Reports root/ big
OK: 3053 / Failed: 1 / User-skipped: 228 / Auto-skipped: 0

mam_SUITE:rdbms_cache_prefs_cases:messages_filtered_when_prefs_default_policy_is_roster
{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}

Report log


mssql_mnesia_24 / odbc_mssql_mnesia / aa9fc85
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / aa9fc85
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 319 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #3285 (aa9fc85) into master (3ad1bfd) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3285      +/-   ##
==========================================
+ Coverage   80.20%   80.23%   +0.03%     
==========================================
  Files         398      398              
  Lines       32560    32560              
==========================================
+ Hits        26114    26125      +11     
+ Misses       6446     6435      -11     
Impacted Files Coverage Δ
src/metrics/mongoose_metrics.erl 95.45% <0.00%> (-0.65%) ⬇️
src/mod_muc.erl 73.99% <0.00%> (ø)
src/mod_bosh_socket.erl 79.19% <0.00%> (+0.31%) ⬆️
src/ejabberd_sm.erl 84.59% <0.00%> (+0.32%) ⬆️
src/pubsub/mod_pubsub_db_mnesia.erl 92.85% <0.00%> (+0.42%) ⬆️
src/mam/mod_mam.erl 89.16% <0.00%> (+0.83%) ⬆️
src/mam/mod_mam_elasticsearch_arch.erl 86.84% <0.00%> (+1.75%) ⬆️
...c/global_distrib/mod_global_distrib_server_mgr.erl 76.83% <0.00%> (+2.25%) ⬆️
src/elasticsearch/mongoose_elasticsearch.erl 84.61% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad1bfd...aa9fc85. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@chrzaszcz chrzaszcz merged commit 22edc82 into master Sep 17, 2021
@chrzaszcz chrzaszcz deleted the metrics-register-use-host_type branch September 17, 2021 09:00
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants