C2s/merge master #3816
C2s/merge master #3816
Conversation
NelsonVides
commented
Oct 19, 2022
•
NelsonVides
commented
Refactored hook handler in mod_jingle_sip module
Refactored hook handlers in mod_inbox module
Adding support for http calling of the graphql_server commands
Refactored hook handlers in mod_mam_pm module
Remove imports, use library function [refactor]
use jid:are_bare_equal instead of writing the same function in the modules.
don't use imports in mam to make code a bit cleaner - we usually use the imported function only once.
This functionality will be needed to support the Client REST API. GraphQL should support sending chat markers as well, but this is left for a future PR. The support for markers could be placed in this module, and shared by both API's. Also: - export user affiliation getter for use in the API modules - fix a minor mistake (double nesting of 'error')
Both modules expose the generic helpers now. The admin code is not simply reused because of slight differences, e.g. with authentication and error handling.
Use mongoose_stanza_* helper modules.
Remove the logic using 'resource_exists' for consistency with the other API modules, and for avoiding duplicate calls to MUC Light modules.
Rework the permission-related code
- Catch the case when another type is passed instead of binary - Respond with a validation error (as expected) instead of crashing
- Update error messages and codes - Fix typos and dead test cases - Improve coverage by handling more error cases
Convert mod_offline modules to gen_hook
Convert mod_vcard to gen_hook
Refactored hook handlers in mod_adhoc
Refactored hook handlers in mod_blocking
Co-authored-by: Kamil Wąż <kamil@kamilwaz.com>
Refactored hook handlers in mod_http_upload
Refactored hook handlers in mod_auth_token
Refactored hook handlers in mod_bosh
Refactored hook handlers in mongoose_metrics_mam_hooks
NelsonVides
force-pushed
the
c2s/merge_master
branch
from
e30aed0
to
71e9f93
Compare
This comment was marked as outdated.
This comment was marked as outdated.
NelsonVides
force-pushed
the
c2s/merge_master
branch
from
71e9f93
to
207ec0c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
In commit 57a5e59, we removed checking that the return of the `rpc:multicall/X` didn't fail.
|
small_tests_24 / small_tests / bdcd811 small_tests_25 / small_tests / bdcd811 ldap_mnesia_24 / ldap_mnesia / bdcd811 ldap_mnesia_25 / ldap_mnesia / bdcd811 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / bdcd811 pgsql_mnesia_24 / pgsql_mnesia / bdcd811 internal_mnesia_25 / internal_mnesia / bdcd811 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / bdcd811 dynamic_domains_mysql_redis_25 / mysql_redis / bdcd811 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / bdcd811 riak_mnesia_24 / riak_mnesia / bdcd811 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / bdcd811 pgsql_mnesia_25 / pgsql_mnesia / bdcd811 mysql_redis_25 / mysql_redis / bdcd811 mssql_mnesia_25 / odbc_mssql_mnesia / bdcd811 |
