-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C2s/merge master #3858
C2s/merge master #3858
Conversation
- Subscriptions can be executed only with SSE. - Queries and mutations can be executed with HTTP or CLI.
This makes it possible to the execute a prepared subscription operation upon receiving each event. Also: make it possible to return 'aux' data.
It uses lasse, just like the REST SSE handler
- Handle SSE requests under the '/sse' subpath - Export utils used by the SSE handler - Allow passing parameters with GET (qs) or POST (body). This follows the GraphQL specs, and allows to handle SSE.
- unsupported operation - invalid query string
This common code is used by REST and GraphQL SSE handlers.
This is actually used only for building the queries for tests. The commands will be displayed in the CLI help - we can change this later if needed.
Put the more generic tests (mostly error handling) in a separate suite.
GraphQL subscriptions for stanzas
Refactored hook handlers in mod_cache_users
Update expected results: - Errors on duplicate operations - New error messages - Deleted domain is not nested
Update expected results: - Two-element tuples are returned from the external API - Database errors don't have special handling - Errors on duplicate operations - New error messages
Improve error handling in API module last
Refactored hook handlers in mod_keystore
Refactored hook handlers in mod_domain_isolation
Rework domain API module
Improve error handling in gdpr_api
Convert mod_mam to gen_hook
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 72.09% // Head: 72.24% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feature/mongoose_c2s #3858 +/- ##
========================================================
+ Coverage 72.09% 72.24% +0.15%
========================================================
Files 534 541 +7
Lines 34009 34198 +189
========================================================
+ Hits 24518 24708 +190
+ Misses 9491 9490 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bdd84d0
to
ed65ceb
Compare
small_tests_24 / small_tests / ed65ceb small_tests_25 / small_tests / ed65ceb ldap_mnesia_24 / ldap_mnesia / ed65ceb ldap_mnesia_25 / ldap_mnesia / ed65ceb dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ed65ceb pgsql_mnesia_24 / pgsql_mnesia / ed65ceb internal_mnesia_25 / internal_mnesia / ed65ceb elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / ed65ceb dynamic_domains_mysql_redis_25 / mysql_redis / ed65ceb dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / ed65ceb pgsql_mnesia_25 / pgsql_mnesia / ed65ceb riak_mnesia_24 / riak_mnesia / ed65ceb mysql_redis_25 / mysql_redis / ed65ceb dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / ed65ceb mssql_mnesia_25 / odbc_mssql_mnesia / ed65ceb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
All conflicts were related to hooks changes and fixes were very straightforward. Only note is in
mod_vcard
, where an iq handler had defined the extra parameter asgen_hook:extra()
, but it is an iq handler, not a hook handler. Confusing enough, but dialyzer complained :)