Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIM-865 minor fixes #146

Merged
merged 7 commits into from
Apr 2, 2020
Merged

MIM-865 minor fixes #146

merged 7 commits into from
Apr 2, 2020

Conversation

leszke
Copy link
Contributor

@leszke leszke commented Apr 1, 2020

This spontaneous PR covers comments arisen during our remote-peer-review with @rslota after his coming back from holiday. Some naming alignments, more response codes for APIv1, added SwaggerUI for diagnostic purposes (to be hidden from production in near future!).

@leszke leszke requested a review from rslota April 1, 2020 16:58
"not for any client usage, as it may change in time without prior notice."
}
},
example: %{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add an example here (from tests?).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@rslota rslota merged commit 25ec963 into master Apr 2, 2020
@rslota rslota deleted the mim-865-minor-fixes branch April 2, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants