Controller/tests #170
Merged
Controller/tests #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #170 +/- ##
===========================================
+ Coverage 33.23% 47.60% +14.37%
===========================================
Files 23 23
Lines 981 981
===========================================
+ Hits 326 467 +141
+ Misses 655 514 -141 ☔ View full report in Codecov by Sentry. |
test/controller_SUITE.erl
Outdated
| do_start_scenario(testing_scenario, regular_vars()), | ||
| amoc_controller:add_users(1, 10), | ||
| Status = amoc_controller:get_status(), | ||
| ?assertMatch({running, testing_scenario, _, 10}, Status). |
There was a problem hiding this comment.
think we should check the number of users as well:
?assertEqual({running, testing_scenario, 10, 10}, Status)
and it's better to use range starting from some other value than 1:
amoc_controller:add_users(6, 10),
Status = amoc_controller:get_status(),
timer:sleep(50*6), % enough time to start 6 users with 50ms interarrival
?assertEqual({running, testing_scenario, 5, 10}, Status).
test/controller_SUITE.erl
Outdated
|
|
||
| wait_until_scenario_has_users(Scenario, Current, Total) -> | ||
| WaitUntilFun = fun amoc_controller:get_status/0, | ||
| WaitUntilValue = {running, Scenario, Current, Total}, |
There was a problem hiding this comment.
that's not total, but the highest user ID used by the controller
| ?assertMatch({running, testing_scenario, _, 10}, Status). | ||
| StartId = 6, | ||
| EndId = 10, | ||
| amoc_controller:add_users(6, 10), |
There was a problem hiding this comment.
why not amoc_controller:add_users(StartId, EndId),
anyway, that's not blocking.
DenysGonchar
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.