Controller/improvements and tests #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NelsonVides
force-pushed
the
controller/improvements_and_tests
branch
2 times, most recently
from
e099115
to
24c223a
Compare
NelsonVides
force-pushed
the
controller/improvements_and_tests
branch
from
24c223a
to
f777f7b
Compare
NelsonVides
force-pushed
the
telemetry/timestamps_and_spans
branch
from
57620b4
to
b565018
Compare
NelsonVides
force-pushed
the
controller/improvements_and_tests
branch
from
f777f7b
to
2a07eb9
Compare
NelsonVides
force-pushed
the
telemetry/timestamps_and_spans
branch
5 times, most recently
from
b834956
to
c494c65
Compare
NelsonVides
force-pushed
the
controller/improvements_and_tests
branch
from
2a07eb9
to
d308bb8
Compare
NelsonVides
force-pushed
the
controller/improvements_and_tests
branch
2 times, most recently
from
f1e3d32
to
a0d167b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
===========================================
+ Coverage 33.23% 48.35% +15.12%
===========================================
Files 23 23
Lines 975 1001 +26
===========================================
+ Hits 324 484 +160
+ Misses 651 517 -134 ☔ View full report in Codecov by Sentry. |
In the original implementation, the process is monitored by two supervisors, the original amoc_users_sup, and the amoc_controller one. But this means that bursts of ups and downs overflow the mailbox of _two_ processes, one of them being actually the very critical controller. With this reimplementation, only the amoc_users_sup tracks the processes, and all requests from the controller are asynchronous. This ensures the controller does not get blocked and can remain responsive to control requests.
NelsonVides
force-pushed
the
controller/improvements_and_tests
branch
from
a0d167b
to
53c1795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after #162
Mainly this introduces separation between the controller and the users supervisor, and unit tests for them. See commits for details.