Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codecov plugin #43

Merged
merged 3 commits into from
Sep 10, 2018
Merged

Codecov plugin #43

merged 3 commits into from
Sep 10, 2018

Conversation

zofpolkowska
Copy link

After migrating to rebar3, add codecov plugin

@zofpolkowska zofpolkowska force-pushed the codecov_plugin branch 4 times, most recently from 057abab to 3bad8c4 Compare September 7, 2018 11:56
@codecov-io
Copy link

codecov-io commented Sep 7, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@82e93c3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #43   +/-   ##
=========================================
  Coverage          ?   87.31%           
=========================================
  Files             ?        4           
  Lines             ?      134           
  Branches          ?        0           
=========================================
  Hits              ?      117           
  Misses            ?       17           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82e93c3...4c78bfc. Read the comment docs.

@zofpolkowska zofpolkowska force-pushed the codecov_plugin branch 2 times, most recently from 4e849c1 to 4c78bfc Compare September 10, 2018 08:10
michalwski
michalwski reviewed Sep 10, 2018
View reviewed changes
.travis.yml Outdated
script:
- make test
- make dialyzer
- make codecov
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense only in case of success as the coverage report is sent only then.

michalwski
michalwski reviewed Sep 10, 2018
View reviewed changes
Makefile Outdated
rebar:
wget https://github.com/rebar/rebar/releases/download/2.5.1/rebar &&\
chmod u+x rebar
codecov: rebar3 test
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test target will be executed twice now, see https://travis-ci.org/esl/exml/jobs/426567957#L589 and https://travis-ci.org/esl/exml/jobs/426567957#L653

I think it's enough set the same dependencies for the codecov target as for coverage-report.

michalwski
michalwski suggested changes Sep 10, 2018
View reviewed changes
Copy link

@michalwski michalwski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some parts of the changes could be improved. See my comments to the code.

@zofpolkowska zofpolkowska force-pushed the codecov_plugin branch 2 times, most recently from 7869f5e to 7350547 Compare September 10, 2018 10:17
@michalwski michalwski merged commit 9e45f54 into master Sep 10, 2018
@michalwski michalwski deleted the codecov_plugin branch September 10, 2018 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalwski michalwski michalwski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zofpolkowska @codecov-io @michalwski