Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR again tunes code here. Removing some bug verification not needed since OTP20, and also removing copying of atoms, makes the object code 10% smaller (
exml_nif.so
goes from 1MB to 909KB), which adds to the fact that there's a bit less to compute, and improves throughput for the parser by 10%. Which btw, copying (attempting to copy!) atoms should have never been necessary, atoms are global and they don't depend whatsoever in the environment in which they're added, so theenif_make_copy/2
call would do nothing more than checking the atom is already available in the global atom table, which is a waste of checks.Also adding prettier docs to the hex package.
Fixes #36