Even port and reservations #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerboabot
reviewed
May 11, 2017
|
|
||
| test "returns valid allocate request with RESERVATION-TOKEN attribute" do | ||
| creds = CH.final() | ||
| token = <<0::8*8>> # token must be 8 bytes long |
There was a problem hiding this comment.
There are spaces around operators most of the time, but not here.
| @spec allocate_response_handler :: Transaction.handler | ||
| defp allocate_response_handler do | ||
| @spec allocate_response_handler(Client.allocate_opts) :: Transaction.handler | ||
| defp allocate_response_handler(opts) do |
There was a problem hiding this comment.
Function is too complex (ABC size is 35, max is 30).
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/esl/jerboa/pulls/111. |
|
I don't have any change requests or comments. Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for three additional options which may be passed to
Client.allocate/2:even_port: truewhich makes the client request even port without reservationreserve: truewhich makes the client request even port with reservationreservation_token: <token>which makes the client use previously obtained reservation token for the allocation