New features and enhancements #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also enhanced the lhttpc_lib:parse_url/1 to parse credentials as specified in RFC1738 - before if user credentials were specified, this function would consider that what follows the first : is the port and not a password.
If an URL targets an IPv6 host, lhttpc will now pass the inet6 option to the socket automatically. This also fixes 2 bugs: 1) in lhttpc_lib:parse_url/1 when the host component is an IPv6 address literal - the parser thinks that what follows the first : is a port number; 2) for IPv6 address literals, the Host header must surround those literals in square brackets (RFC2732)
This change adds support for HTTP proxies that allow the HTTP CONNECT method tunneling [1, 2]. Tested against Squid 3.1.15. [1] http://muffin.doit.org/docs/rfc/tunneling_ssl.html [2] http://tools.ietf.org/html/rfc2817
This allows the connection pool (lhttpc_manager) to block clients, when they request a socket, when the current number of open sockets/connection reaches a certain (configurable) threshold.
This test verifies that the lhttpc_manager pool closes sockets if they are not used after a configurable period of time.
This change allows different clients to use different connection pools (lhttpc_manager instances). This is useful when we have several different applications or process groups which are independent and shouldn't share the same pool. It also reduces the overhead of messaging a single centralized pool.
This helps better identifying which tests fail and give a notion of progress/staleness.
g-andrade
pushed a commit
to g-andrade/lhttpc
that referenced
this pull request
Nov 26, 2014
Use os:timestamp instead of erlang:now for link expiration
g-andrade
pushed a commit
to g-andrade/lhttpc
that referenced
this pull request
Nov 26, 2014
GetEndpointAttributes implementation
massemanet
pushed a commit
to campanja-forks/lhttpc
that referenced
this pull request
Mar 9, 2017
Merge me - combination of two previous PR
g-andrade
added a commit
to g-andrade/lhttpc
that referenced
this pull request
Aug 7, 2018
Fix rebar2 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've been integrating lhttpc with Apache CouchDB (to replace ibrowse), but it lacked a few features that are currently supported by ibrowse. This pull requests adds those features and enhances the httpc connection pool (so that it can replace the custom one from CouchDB).
I also made a pull request to Oscar, but it's been a long time and got no feedback:
oscarh/lhttpc#3
thanks