Bug: no-callback-literal

[JounQin]

Environment

Node version: v20.10.0
npm version: 10.2.3
ESLint version: v8.56.0
eslint-plugin-n version: 16.6.1
Operating System: macOS 14

What rule do you want to report?

no-callback-literal

Link to Minimal Reproducible Example

N/A

What did you expect to happen?

let result: string

try {
  result = renderToString(component)

  if (options.template) {
    result = templateRenderer.renderSync(result, context)
  }
  cb(null, result)
} catch (err) {
  cb(err as Error) // `Unexpected literal in error position of callback.` error here
}

Participation

• I am willing to submit a pull request for this issue.

Additional comments

No response

[scagood]

Mmm, I am just taking a quick look on my phone and I can't see anything that is immediately obvious.

After taking a look at the ast, maybe we should add TSAsExpression to the couldBeError function 🤔

https://github.com/eslint-community/eslint-plugin-n/blob/master/lib/rules/no-callback-literal.js#L56

It may be worth giving that a try, but I can also try look in a day or two if that does not work

[aladdin-add]

we could just ignore unknown nodes - to avoid possible false positives. will make a PR later.