Allow dynamic import for Node.js >=12.17 <13 || >=13.2 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extend case.supported to support explicit Range instances * Update error string * Update tests to check around those constraints
|
Hello at the new location! Surprisingly no rebase conflicts on the new work here 🎉. All unit tests passed locally. |
|
released in v15.1.0 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR was moved from mysticatea#256 as that repository is currently unmaintained.)
Summary
This attempts to resolve mysticatea#250 by specifying the supported version for dynamic imports. Check the original PR for discussions I opened on the code around some of my changes.
Changes
case.supportedto support explicitRangeinstancesno-dynamic-import