Merge pull request #21 from jonaskello/rule/no-delete

chore: Remove no-delete rule.
eslint-functional · Jul 15, 2019 · b2f5568 · b2f5568
2 parents 2dee1ba + a99ca1d
commit b2f5568
Show file tree

Hide file tree

Showing 8 changed files with 1 addition and 142 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -33,7 +33,6 @@
     // Our rules.
     "ts-immutable/immutable-data": "error",
     "ts-immutable/no-let": "error",
-    "ts-immutable/no-delete": "error",
     "ts-immutable/readonly-array": ["error", { "ignoreReturnType": true }],
     "ts-immutable/readonly-keyword": "error",
     "ts-immutable/no-method-signature": "error",

diff --git a/README.md b/README.md
@@ -117,7 +117,6 @@ In addition to immutable rules this project also contains a few rules for enforc
 | [`ts-immutable/no-let`](./docs/rules/no-let.md)                           | Disallow mutable variables                                                 |               :heavy_check_mark:               |                 :heavy_check_mark:                  |               :heavy_check_mark:                | :wrench: |                   |
 | [`ts-immutable/immutable-data`](./docs/rules/immutable-data.md)           | Disallow mutating objects and arrays                                       |               :heavy_check_mark:               |                 :heavy_check_mark:                  |               :heavy_check_mark:                |          |   :blue_heart:    |
 | [`ts-immutable/no-method-signature`](./docs/rules/no-method-signature.md) | Enforce property signatures with readonly modifiers over method signatures |               :heavy_check_mark:               |                 :heavy_check_mark:                  |               :heavy_check_mark:                |          | :thought_balloon: |
-| [`ts-immutable/no-delete`](./docs/rules/no-delete.md)                     | Disallow delete expressions                                                |               :heavy_check_mark:               |                 :heavy_check_mark:                  |               :heavy_check_mark:                |          |                   |
 
 ### Functional style rules
 

diff --git a/docs/rules/no-delete.md b/docs/rules/no-delete.md
diff --git a/src/configs/all.ts b/src/configs/all.ts
@@ -2,7 +2,6 @@ const config = {
   rules: {
     "ts-immutable/immutable-data": "error",
     "ts-immutable/no-class": "error",
-    "ts-immutable/no-delete": "error",
     "ts-immutable/no-expression-statement": "error",
     "ts-immutable/no-if-statement": "error",
     "ts-immutable/no-let": "error",

diff --git a/src/configs/immutable.ts b/src/configs/immutable.ts
@@ -7,8 +7,7 @@ const config = deepMerge([
   {
     rules: {
       "ts-immutable/no-let": "error",
-      "ts-immutable/immutable-data": "error",
-      "ts-immutable/no-delete": "error"
+      "ts-immutable/immutable-data": "error"
     },
     overrides: [
       {

diff --git a/src/rules/index.ts b/src/rules/index.ts
@@ -3,7 +3,6 @@ import {
   rule as immutableDataRule
 } from "./immutable-data";
 import { name as noClassRuleName, rule as noClassRule } from "./no-class";
-import { name as noDeleteRuleName, rule as noDeleteRule } from "./no-delete";
 import {
   name as noExpressionStatementRuleName,
   rule as noExpressionStatementRule
@@ -44,7 +43,6 @@ import {
 export const rules = {
   [immutableDataRuleName]: immutableDataRule,
   [noClassRuleName]: noClassRule,
-  [noDeleteRuleName]: noDeleteRule,
   [noExpressionStatementRuleName]: noExpressionStatementRule,
   [noIfStatementRuleName]: noIfStatementRule,
   [noLetRuleName]: noLetRule,

diff --git a/src/rules/no-delete.ts b/src/rules/no-delete.ts
diff --git a/tests/rules/no-delete.test.ts b/tests/rules/no-delete.test.ts