Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove no-delete rule. #21

Merged
merged 4 commits into from Jul 15, 2019
Merged

chore: Remove no-delete rule. #21

merged 4 commits into from Jul 15, 2019

Conversation

RebeccaStevens
Copy link
Collaborator

Fixes #12

@RebeccaStevens RebeccaStevens added the Feature Removal A feature is no longer wanted/needed (remove/deprecate it) label Jul 14, 2019
@codecov-io
Copy link

codecov-io commented Jul 15, 2019

Codecov Report

Merging #21 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage    89.7%   89.67%   -0.04%     
==========================================
  Files          29       28       -1     
  Lines         408      397      -11     
  Branches       72       71       -1     
==========================================
- Hits          366      356      -10     
  Misses         33       33              
+ Partials        9        8       -1
Impacted Files Coverage Δ
src/configs/all.ts 0% <ø> (ø) ⬆️
src/rules/index.ts 100% <ø> (ø) ⬆️
src/configs/immutable.ts 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e1c88...d1cb8c7. Read the comment docs.

@RebeccaStevens RebeccaStevens merged commit fe55549 into master Jul 15, 2019
@RebeccaStevens RebeccaStevens deleted the rule/no-delete branch July 18, 2019 03:02
RebeccaStevens pushed a commit that referenced this pull request Jan 4, 2021
chore: Remove no-delete rule.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Removal A feature is no longer wanted/needed (remove/deprecate it)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-delete] Deprecate rule
2 participants