Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove no-delete rule. #21

Merged
merged 4 commits into from Jul 15, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintrc
Expand Up @@ -33,7 +33,6 @@
// Our rules.
"ts-immutable/immutable-data": "error",
"ts-immutable/no-let": "error",
"ts-immutable/no-delete": "error",
"ts-immutable/readonly-array": ["error", { "ignoreReturnType": true }],
"ts-immutable/readonly-keyword": "error",
"ts-immutable/no-method-signature": "error",
Expand Down
1 change: 0 additions & 1 deletion README.md
Expand Up @@ -117,7 +117,6 @@ In addition to immutable rules this project also contains a few rules for enforc
| [`ts-immutable/no-let`](./docs/rules/no-let.md) | Disallow mutable variables | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | :wrench: | |
| [`ts-immutable/immutable-data`](./docs/rules/immutable-data.md) | Disallow mutating objects and arrays | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | | :blue_heart: |
| [`ts-immutable/no-method-signature`](./docs/rules/no-method-signature.md) | Enforce property signatures with readonly modifiers over method signatures | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | | :thought_balloon: |
| [`ts-immutable/no-delete`](./docs/rules/no-delete.md) | Disallow delete expressions | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | | |

### Functional style rules

Expand Down
19 changes: 0 additions & 19 deletions docs/rules/no-delete.md

This file was deleted.

1 change: 0 additions & 1 deletion src/configs/all.ts
Expand Up @@ -2,7 +2,6 @@ const config = {
rules: {
"ts-immutable/immutable-data": "error",
"ts-immutable/no-class": "error",
"ts-immutable/no-delete": "error",
"ts-immutable/no-expression-statement": "error",
"ts-immutable/no-if-statement": "error",
"ts-immutable/no-let": "error",
Expand Down
3 changes: 1 addition & 2 deletions src/configs/immutable.ts
Expand Up @@ -7,8 +7,7 @@ const config = deepMerge([
{
rules: {
"ts-immutable/no-let": "error",
"ts-immutable/immutable-data": "error",
"ts-immutable/no-delete": "error"
"ts-immutable/immutable-data": "error"
},
overrides: [
{
Expand Down
2 changes: 0 additions & 2 deletions src/rules/index.ts
Expand Up @@ -3,7 +3,6 @@ import {
rule as immutableDataRule
} from "./immutable-data";
import { name as noClassRuleName, rule as noClassRule } from "./no-class";
import { name as noDeleteRuleName, rule as noDeleteRule } from "./no-delete";
import {
name as noExpressionStatementRuleName,
rule as noExpressionStatementRule
Expand Down Expand Up @@ -44,7 +43,6 @@ import {
export const rules = {
[immutableDataRuleName]: immutableDataRule,
[noClassRuleName]: noClassRule,
[noDeleteRuleName]: noDeleteRule,
[noExpressionStatementRuleName]: noExpressionStatementRule,
[noIfStatementRuleName]: noIfStatementRule,
[noLetRuleName]: noLetRule,
Expand Down
63 changes: 0 additions & 63 deletions src/rules/no-delete.ts

This file was deleted.

53 changes: 0 additions & 53 deletions tests/rules/no-delete.test.ts

This file was deleted.