fix(padding-line-between-statements): recognize ExportAllDeclaration …

…nodes (#257) * fix(padding-line-between-statements): recognize ExportAllDeclaration nodes * chore: update * chore: add comments --------- Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
eslint-stylistic · Jan 8, 2024 · 52f0506 · 52f0506
1 parent 59070ae
commit 52f0506
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 0 deletions.
diff --git a/...t-plugin-js/rules/padding-line-between-statements/padding-line-between-statements.test.ts b/...t-plugin-js/rules/padding-line-between-statements/padding-line-between-statements.test.ts
@@ -745,6 +745,15 @@ ruleTester.run('padding-line-between-statements', rule, {
       ],
       parserOptions: { ecmaVersion: 6, sourceType: 'module' },
     },
+    // https://github.com/eslint-stylistic/eslint-stylistic/pull/257
+    {
+      code: 'var a = 0; export * from "foo"\n\nbar()',
+      options: [
+        { blankLine: 'never', prev: '*', next: '*' },
+        { blankLine: 'always', prev: 'export', next: '*' },
+      ],
+      parserOptions: { ecmaVersion: 6, sourceType: 'module' },
+    },
 
     // ----------------------------------------------------------------------
     // for
@@ -3571,6 +3580,16 @@ ruleTester.run('padding-line-between-statements', rule, {
       parserOptions: { ecmaVersion: 6, sourceType: 'module' },
       errors: [{ messageId: 'expectedBlankLine' }],
     },
+    // https://github.com/eslint-stylistic/eslint-stylistic/pull/257
+    {
+      code: 'var a = 0;export * from "foo"\nbar()',
+      output: 'var a = 0;export * from "foo"\n\nbar()',
+      options: [
+        { blankLine: 'always', prev: 'export', next: '*' },
+      ],
+      parserOptions: { ecmaVersion: 6, sourceType: 'module' },
+      errors: [{ messageId: 'expectedBlankLine' }],
+    },
 
     // ----------------------------------------------------------------------
     // for

diff --git a/...t-plugin-ts/rules/padding-line-between-statements/padding-line-between-statements.test.ts b/...t-plugin-ts/rules/padding-line-between-statements/padding-line-between-statements.test.ts
@@ -763,6 +763,15 @@ ruleTester.run('padding-line-between-statements', rule, {
       ],
       parserOptions: { ecmaVersion: 6, sourceType: 'module' },
     },
+    // https://github.com/eslint-stylistic/eslint-stylistic/pull/257
+    {
+      code: 'var a = 0; export * from "foo"\n\nbar()',
+      options: [
+        { blankLine: 'never', prev: '*', next: '*' },
+        { blankLine: 'always', prev: 'export', next: '*' },
+      ],
+      parserOptions: { ecmaVersion: 6, sourceType: 'module' },
+    },
 
     // ----------------------------------------------------------------------
     // for
@@ -3530,6 +3539,14 @@ var a = 1
       parserOptions: { ecmaVersion: 6, sourceType: 'module' },
       errors: [{ messageId: 'expectedBlankLine' }],
     },
+    // https://github.com/eslint-stylistic/eslint-stylistic/pull/257
+    {
+      code: 'var a = 0;export * from "foo"\nbar()',
+      output: 'var a = 0;export * from "foo"\n\nbar()',
+      options: [{ blankLine: 'always', prev: 'export', next: '*' }],
+      parserOptions: { ecmaVersion: 6, sourceType: 'module' },
+      errors: [{ messageId: 'expectedBlankLine' }],
+    },
 
     // ----------------------------------------------------------------------
     // for

diff --git a/...eslint-plugin-ts/rules/padding-line-between-statements/padding-line-between-statements.ts b/...eslint-plugin-ts/rules/padding-line-between-statements/padding-line-between-statements.ts
@@ -547,6 +547,7 @@ const StatementTypes: Record<string, NodeTestObject> = {
   'do': newKeywordTester(AST_NODE_TYPES.DoWhileStatement, 'do'),
   'export': newKeywordTester(
     [
+      AST_NODE_TYPES.ExportAllDeclaration,
       AST_NODE_TYPES.ExportDefaultDeclaration,
       AST_NODE_TYPES.ExportNamedDeclaration,
     ],