fix: use sponsor's GitHub username when name is missing (#392)

* fix: set fallback value * fix: set fallback for name * revert change to sponsors.html * set another fallback * clean up dirty data
eslint · Dec 25, 2022 · 17a9cd8 · 17a9cd8
1 parent cd03054
commit 17a9cd8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 40 deletions.
diff --git a/src/_data/donations.json b/src/_data/donations.json
@@ -251,15 +251,6 @@
         "date": "2022-02-21T11:46:53.444Z",
         "source": "opencollective"
     },
-    {
-        "id": "SA_kwHOAFvahM4ABIzq",
-        "name": null,
-        "image": "https://avatars.githubusercontent.com/u/23113912?u=8f0f72610d5ec4a8bd382680e693984210b1cf18&v=4",
-        "url": "https://github.com/ndNovaDev",
-        "amount": 10,
-        "date": "2022-12-24T02:22:57Z",
-        "source": "github"
-    },
     {
         "id": "SA_kwHOAFvahM4ABHcn",
         "name": "Gabriel Gregório",
@@ -269,4 +260,4 @@
         "date": "2022-12-07T23:22:34Z",
         "source": "github"
     }
-]
+]
diff --git a/src/_data/sponsors.json b/src/_data/sponsors.json
@@ -452,14 +452,6 @@
             "source": "github",
             "tier": "backer"
         },
-        {
-            "name": null,
-            "image": "https://avatars.githubusercontent.com/u/23113912?u=8f0f72610d5ec4a8bd382680e693984210b1cf18&v=4",
-            "url": "https://github.com/ndNovaDev",
-            "monthlyDonation": 10,
-            "source": "github",
-            "tier": "backer"
-        },
         {
             "name": "Raimonds Korzenevskis",
             "image": "https://avatars.githubusercontent.com/u/28185559?u=4e564dd0947ebc75d9fe02a90b7149256a48164e&v=4",
@@ -1228,14 +1220,6 @@
             "source": "github",
             "tier": "backer"
         },
-        {
-            "name": null,
-            "image": "https://avatars.githubusercontent.com/u/8572152?v=4",
-            "url": "https://github.com/per1234",
-            "monthlyDonation": 5,
-            "source": "github",
-            "tier": "backer"
-        },
         {
             "name": "Gabi",
             "image": "https://avatars.githubusercontent.com/u/9082013?u=0a2400198d68bd7155832384f6135c22aefa6f4b&v=4",
@@ -1324,14 +1308,6 @@
             "source": "github",
             "tier": "backer"
         },
-        {
-            "name": null,
-            "image": "https://avatars.githubusercontent.com/u/19206886?u=5302740136db6d2fe4d4009680064ce95a1896fc&v=4",
-            "url": "https://github.com/portfine",
-            "monthlyDonation": 5,
-            "source": "github",
-            "tier": "backer"
-        },
         {
             "name": "BrightCrowd",
             "image": "https://avatars.githubusercontent.com/u/19253501?v=4",
@@ -1529,4 +1505,4 @@
             "tier": "backer"
         }
     ]
-}
+}
diff --git a/tools/fetch-sponsors.js b/tools/fetch-sponsors.js
@@ -227,7 +227,7 @@ async function fetchGitHubSponsors() {
     // return an array in the same format as Open Collective
     const sponsors = organization.sponsorshipsAsMaintainer.nodes
         .map(({ sponsor, tier }) => ({
-            name: sponsor.name,
+            name: sponsor.name || sponsor.login,
             image: sponsor.avatarUrl,
             url: sponsor.websiteUrl || sponsor.url,
             monthlyDonation: tier.monthlyPriceInDollars,
@@ -239,7 +239,7 @@ async function fetchGitHubSponsors() {
         .filter(transaction => transaction.tier && transaction.tier.isOneTime)
         .map(({ sponsor, timestamp, tier, id }) => ({
             id,
-            name: sponsor.name,
+            name: sponsor.name || sponsor.login,
             image: sponsor.avatarUrl,
             url: sponsor.websiteUrl || sponsor.url,
             amount: tier.monthlyPriceInDollars,
@@ -249,7 +249,7 @@ async function fetchGitHubSponsors() {
         .filter(donation => {
             // invoiced recurring donations are incorrectly marked as one-time
             const sponsor = sponsors.find(sponsor => sponsor.name === donation.name);
-            
+
             // only include if the amount is different than the monthly amount
             return sponsor ? sponsor.monthlyDonation !== donation.amount : true;
         });
@@ -273,11 +273,11 @@ async function fetchGitHubSponsors() {
         {
             sponsors: openCollectiveSponsors,
             donations: openCollectiveDonations
-        }, 
+        },
         {
             sponsors: githubSponsors,
             donations: githubDonations
-        }, 
+        },
     ] = await Promise.all([
         fetchOpenCollectiveData(),
         fetchGitHubSponsors()