New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use sponsor's GitHub username when name is missing #392

Merged

mdjermanovic merged 5 commits into eslint:main from chenxsan:bugfix/fix-ci

Dec 25, 2022

Contributor

chenxsan commented Dec 24, 2022 •

edited

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request?

The CI has failed because of a null value of name coming from here 415e0bb#diff-ff108750031135fb05819cca15c41069cf217df9c9e21745012a5af2e965c55bR256.

And I can confirm it's not a glitch or something because the Web version of GitHub GraphQL API did return null for this sponsor:

What changes did you make? (Give an overview)

Set a fallback value for name in template.

Currently I'm setting it to '', but I'm not sure it's a good option as it could mess the layout:

But it shouldn't be a problem once the data fetching is done next midnight because there's another fallback value in fetch-sponsors.js, see next.
Set the value of name to login when null in fetch-sponsors.js

Related Issues

Is there anything you'd like reviewers to focus on?


          fix: set fallback value

8bffa82

netlify bot commented Dec 24, 2022 •

edited

👷 Deploy request for es-eslint pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	`089ba10`

eslint-github-bot bot added bug triage labels

netlify bot commented Dec 24, 2022 •

edited

✅ Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`089ba10`
🔍 Latest deploy log	https://app.netlify.com/sites/new-eslint/deploys/63a7ada103f6990008ddf81f
😎 Deploy Preview	https://deploy-preview-392--new-eslint.netlify.app/sponsors
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Dec 24, 2022 •

edited

✅ Deploy Preview for ja-eslint ready!

Name	Link
🔨 Latest commit	`089ba10`
🔍 Latest deploy log	https://app.netlify.com/sites/ja-eslint/deploys/63a7ada15ceaef00081ad9f2
😎 Deploy Preview	https://deploy-preview-392--ja-eslint.netlify.app/sponsors
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Dec 24, 2022 •

edited

✅ Deploy Preview for zh-hans-eslint ready!

Name	Link
🔨 Latest commit	`089ba10`
🔍 Latest deploy log	https://app.netlify.com/sites/zh-hans-eslint/deploys/63a7ada1e6fcdf0008c558fe
😎 Deploy Preview	https://deploy-preview-392--zh-hans-eslint.netlify.app/sponsors
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Dec 24, 2022 •

edited

✅ Deploy Preview for fr-eslint ready!

Name	Link
🔨 Latest commit	`089ba10`
🔍 Latest deploy log	https://app.netlify.com/sites/fr-eslint/deploys/63a7ada11e07e80008db417e
😎 Deploy Preview	https://deploy-preview-392--fr-eslint.netlify.app/sponsors
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Dec 24, 2022 •

edited

✅ Deploy Preview for hi-eslint ready!

Name	Link
🔨 Latest commit	`089ba10`
🔍 Latest deploy log	https://app.netlify.com/sites/hi-eslint/deploys/63a7ada1f8849b0009b933a6
😎 Deploy Preview	https://deploy-preview-392--hi-eslint.netlify.app/sponsors
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Dec 24, 2022 •

edited

✅ Deploy Preview for pt-br-eslint ready!

Name	Link
🔨 Latest commit	`089ba10`
🔍 Latest deploy log	https://app.netlify.com/sites/pt-br-eslint/deploys/63a7ada13e78b30008405165
😎 Deploy Preview	https://deploy-preview-392--pt-br-eslint.netlify.app/sponsors
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Dec 24, 2022 •

edited

✅ Deploy Preview for de-eslint ready!

Name	Link
🔨 Latest commit	`089ba10`
🔍 Latest deploy log	https://app.netlify.com/sites/de-eslint/deploys/63a7ada1601b73000802b5ce
😎 Deploy Preview	https://deploy-preview-392--de-eslint.netlify.app/sponsors
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Contributor Author

chenxsan commented Dec 24, 2022

As you can see from the actions, CI no longer fails like #391


          fix: set fallback for name

6198c28

chenxsan commented

View reviewed changes

src/content/pages/sponsors.html Outdated Show resolved Hide resolved

harish-sethuraman reviewed

View reviewed changes

tools/fetch-sponsors.js Show resolved Hide resolved

harish-sethuraman mentioned this pull request

fix: searchbar focus on Esc key press #393

Merged

1 task

mdjermanovic reviewed

View reviewed changes

tools/fetch-sponsors.js Show resolved Hide resolved

chenxsan added 3 commits

December 25, 2022 09:52


          revert change to sponsors.html

dad1a82


          set another fallback

0c372ce


          clean up dirty data

089ba10

Contributor Author

chenxsan commented Dec 25, 2022 •

edited

Here's an update of the latest changes:

Use sponsor.login as the fallback value for sponsor.name in case it's null, there're two places in fetch-sponsors.js.
Clean up dirty data in sponsors.json and donations.json to fix the CI, the latest data will be fetched at next midnight according to data-fetch.yml .

mdjermanovic changed the title ~~fix: set fallback value~~ fix: use sponsor's GitHub username when name is missing

mdjermanovic added accepted and removed triage labels

Member

mdjermanovic commented Dec 25, 2022

I thought that we remove the entry from donations.json (as that's causing build failures) while keeping sponsors.json the same until the next automated fetch which will replace nulls with usernames. Can you revert sponsors.json? If not, I'll merge as-is, since the entries will get back in a few hours anyways.

amareshsm approved these changes

View reviewed changes

Member

amareshsm left a comment

LGTM

Member

amareshsm commented Dec 25, 2022

I thought that we remove the entry from donations.json (as that's causing build failures) while keeping sponsors.json the same until the next automated fetch which will replace nulls with usernames. Can you revert sponsors.json? If not, I'll merge as-is, since the entries will get back in a few hours anyways.

we can merge this.

mdjermanovic approved these changes

View reviewed changes

Member

mdjermanovic left a comment

LGTM, thanks!

mdjermanovic merged commit 17a9cd8 into eslint:main

chenxsan deleted the bugfix/fix-ci branch

December 26, 2022 05:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment