Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: [playground]add a button fix all will fix all problems which can be fixed. #549

Open
1 task
zhangenming opened this issue Apr 9, 2024 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@zhangenming
Copy link
Contributor

What problem do you want to solve?

more convenience.

What do you think is the correct solution?

add a selection button.

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response

@zhangenming zhangenming added the enhancement New feature or request label Apr 9, 2024
@Rec0iL99
Copy link
Member

Rec0iL99 commented Apr 9, 2024

Hi @zhangenming, thanks for the issue. Do you mean to add this option for https://eslint.org/play/?

@zhangenming
Copy link
Contributor Author

YES
sorry I forgot to mention

@zhangenming zhangenming changed the title Suggestion: add a option that will auto fix all rules which can be fixed. Suggestion: [playground]add a option that will auto fix all rules which can be fixed. Apr 9, 2024
@nzakas
Copy link
Member

nzakas commented Apr 10, 2024

I'm open to the idea, but we'd need to see a design to make a final decision on whether or not we want to move forward.

@zhangenming
Copy link
Contributor Author

This is just a web page not a API
Does not cause big breaking changes
What I mean is that you can implement it boldly and look at user feedback and even withdraw it at the end

This is my idea. Correct me if I'm wrong. Thank you

@zhangenming
Copy link
Contributor Author

In addition, it is necessary to solve this bug #551 before implementing this feat, otherwise it will be triggered more frequently

@zhangenming
Copy link
Contributor Author

zhangenming commented Apr 11, 2024

fix item: no change, just now fix button

fix rule: fix all item (error that by this one rule cause) (Maybe not that useful)

fix all: fix all rule (all errors can be fix) (the Key recommendation of this issue)

@zhangenming zhangenming changed the title Suggestion: [playground]add a option that will auto fix all rules which can be fixed. Suggestion: [playground]add some button can quickly fix existing problems. Apr 11, 2024
@nzakas
Copy link
Member

nzakas commented Apr 11, 2024

@zhangenming Because this is a web application, we really need to see a visual design before considering this. It's easy to say "Add this feature" but without seeing what it would look like we can't make a decision.

@zhangenming
Copy link
Contributor Author

A simple, crude example, or there's a better way
image

@nzakas
Copy link
Member

nzakas commented Apr 12, 2024

And what do each of those buttons do?

Note: I don't think there's any way we'll add three buttons, but I'm trying to understand what it is they're supposed to do.

@zhangenming
Copy link
Contributor Author

And what do each of those buttons do?

here #549 (comment)
thanks

@zhangenming zhangenming changed the title Suggestion: [playground]add some button can quickly fix existing problems. Suggestion: [playground]add a button fix all will fix all problems which can be fixed. Apr 13, 2024
@nzakas
Copy link
Member

nzakas commented May 9, 2024

Thanks for the suggestion. I think the design adds too many buttons. Maybe we could do something like add a single "Fix All" button somewhere?

@amareshsm amareshsm self-assigned this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Evaluating
Development

No branches or pull requests

4 participants