Fix: false negative of no-useless-rename (fixes #6502) (#6506)

eslint · Jun 28, 2016 · 18663d4 · 18663d4
1 parent 0a7936d
commit 18663d4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/rules/no-useless-rename.js b/lib/rules/no-useless-rename.js
@@ -84,7 +84,7 @@ module.exports = {
 
             for (i = 0; i < properties.length; i++) {
                 if (properties[i].shorthand) {
-                    return;
+                    continue;
                 }
 
                 /**
@@ -94,7 +94,7 @@ module.exports = {
                  * so there is no "renaming" occurring here.
                  */
                 if (properties[i].computed || !properties[i].key) {
-                    return;
+                    continue;
                 }
 
                 if (properties[i].key.type === "Identifier" && properties[i].key.name === properties[i].value.name ||

diff --git a/tests/lib/rules/no-useless-rename.js b/tests/lib/rules/no-useless-rename.js
@@ -145,6 +145,12 @@ ruleTester.run("no-useless-rename", rule, {
             parserOptions: { ecmaVersion: 6 },
             errors: ["Destructuring assignment foo unnecessarily renamed."]
         },
+        {
+            code: "let {a, foo: foo} = obj;",
+            output: "let {a, foo} = obj;",
+            parserOptions: { ecmaVersion: 6 },
+            errors: ["Destructuring assignment foo unnecessarily renamed."]
+        },
         {
             code: "let {foo: foo, bar: baz} = obj;",
             output: "let {foo, bar: baz} = obj;",