Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-useless-rename has false negative #6502

Closed
mysticatea opened this issue Jun 22, 2016 · 0 comments
Closed

no-useless-rename has false negative #6502

mysticatea opened this issue Jun 22, 2016 · 0 comments
Assignees
@mysticatea
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules

Comments

@mysticatea
Copy link
Member

What version of ESLint are you using?

  • v2.13.1

What parser (default, Babel-ESLint, etc.) are you using?

  • default

Please show your full configuration:

  • nothing

What did you do? Please include the actual source code causing the issue.

$ echo "const {a, b: b} = obj" | eslint --stdin --env es6 --rule no-useless-rename:error --no-eslintrc

Or in our online demo:

image

What did you expect to happen?

<text>
  1:11  error  Destructuring assignment b unnecessarily renamed  no-useless-rename

✖ 1 problem (1 error, 0 warnings)

What actually happened? Please include the actual, raw output from ESLint.

No errors
@mysticatea mysticatea added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Jun 22, 2016
@mysticatea mysticatea self-assigned this Jun 22, 2016
mysticatea added a commit that referenced this issue Jun 22, 2016
@mysticatea
Fix: false negative of no-useless-rename (fixes #6502)
a9c77d3
@mysticatea mysticatea mentioned this issue Jun 22, 2016
Merged
gyandeeps pushed a commit that referenced this issue Jun 28, 2016
@mysticatea @gyandeeps
Fix: false negative of no-useless-rename (fixes #6502) (#6506)
18663d4
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mysticatea mysticatea

Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mysticatea