Fix : Don't try too hard to find fault in no-implicit-coercion (refs …

…#3402)
eslint · Aug 26, 2015 · 287f41c · 287f41c
1 parent 4458a56
commit 287f41c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 16 deletions.
diff --git a/lib/rules/no-implicit-coercion.js b/lib/rules/no-implicit-coercion.js
@@ -62,8 +62,7 @@ function isBinaryNegatingOfIndexOf(node) {
 function isMultiplyByOne(node) {
     return node.operator === "*" && (
         node.left.type === "Literal" && node.left.value === 1 ||
-        node.right.type === "Literal" && node.right.value === 1 ||
-        node.parent.type === "BinaryExpression" && isMultiplyByOne(node.parent)
+        node.right.type === "Literal" && node.right.value === 1
     );
 }
 
@@ -100,10 +99,6 @@ function getNonNumericOperand(node) {
     if (left.type !== "BinaryExpression" && !isNumeric(left)) {
         return left;
     }
-
-    if (node.parent.type === "BinaryExpression") {
-        return getNonNumericOperand(node.parent);
-    }
 }
 
 /**

diff --git a/tests/lib/rules/no-implicit-coercion.js b/tests/lib/rules/no-implicit-coercion.js
@@ -54,6 +54,13 @@ ruleTester.run("no-implicit-coercion", rule, {
         {code: "1234 * parseInt(foo) * 1 * Number(bar)"},
         {code: "1234 * parseFloat(foo) * 1 * parseInt(bar)"},
         {code: "1234 * parseFloat(foo) * 1 * Number(bar)"},
+        {code: "1234*foo*1"},
+        {code: "1234*1*foo"},
+        {code: "1234*bar*1*foo"},
+        {code: "1234*1*foo*bar"},
+        {code: "1234*1*foo*Number(bar)"},
+        {code: "1234*1*Number(foo)*bar"},
+        {code: "1234*1*parseInt(foo)*bar"},
         {code: "0 + foo"},
         {code: "~foo.bar()"},
 
@@ -72,16 +79,6 @@ ruleTester.run("no-implicit-coercion", rule, {
         {code: "+foo.bar", errors: [{message: "use `Number(foo.bar)` instead.", type: "UnaryExpression"}]},
         {code: "1*foo", errors: [{message: "use `Number(foo)` instead.", type: "BinaryExpression"}]},
         {code: "foo*1", errors: [{message: "use `Number(foo)` instead.", type: "BinaryExpression"}]},
-        {code: "1234*foo*1", errors: [{message: "use `Number(foo)` instead.", type: "BinaryExpression"}]},
-        {code: "1234*1*foo", errors: [{message: "use `Number(foo)` instead.", type: "BinaryExpression"}]},
-        {code: "1234*bar*1*foo", errors: [
-            {message: "use `Number(bar)` instead.", type: "BinaryExpression"},
-            {message: "use `Number(foo)` instead.", type: "BinaryExpression"}
-        ]},
-        {code: "1234*1*foo*bar", errors: [{message: "use `Number(foo)` instead.", type: "BinaryExpression"}]},
-        {code: "1234*1*foo*Number(bar)", errors: [{message: "use `Number(foo)` instead.", type: "BinaryExpression"}]},
-        {code: "1234*1*Number(foo)*bar", errors: [{message: "use `Number(bar)` instead.", type: "BinaryExpression"}]},
-        {code: "1234*1*parseInt(foo)*bar", errors: [{message: "use `Number(bar)` instead.", type: "BinaryExpression"}]},
         {code: "1*foo.bar", errors: [{message: "use `Number(foo.bar)` instead.", type: "BinaryExpression"}]},
         {code: "\"\"+foo", errors: [{message: "use `String(foo)` instead.", type: "BinaryExpression"}]},
         {code: "foo+\"\"", errors: [{message: "use `String(foo)` instead.", type: "BinaryExpression"}]},