Update: add fixer for no-extra-boolean-cast (#7387)

eslint · Nov 1, 2016 · 36338f0 · 36338f0
1 parent 183def6
commit 36338f0
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 3 deletions.
diff --git a/docs/rules/no-extra-boolean-cast.md b/docs/rules/no-extra-boolean-cast.md
@@ -1,5 +1,7 @@
 # disallow unnecessary boolean casts (no-extra-boolean-cast)
 
+(fixable) The `--fix` option on the [command line](../user-guide/command-line-interface#fix) automatically fixes problems reported by this rule.
+
 In contexts such as an `if` statement's test where the result of the expression will already be coerced to a Boolean, casting to a Boolean via double negation (`!!`) or a `Boolean` call is unnecessary. For example, these `if` statements are equivalent:
 
 ```js

diff --git a/lib/rules/no-extra-boolean-cast.js b/lib/rules/no-extra-boolean-cast.js
@@ -17,10 +17,13 @@ module.exports = {
             recommended: true
         },
 
-        schema: []
+        schema: [],
+
+        fixable: "code"
     },
 
     create(context) {
+        const sourceCode = context.getSourceCode();
 
         // Node types which have a test which will coerce values to booleans.
         const BOOLEAN_NODE_TYPES = [
@@ -70,7 +73,11 @@ module.exports = {
                         grandparent.callee.type === "Identifier" &&
                         grandparent.callee.name === "Boolean")
                 ) {
-                    context.report(node, "Redundant double negation.");
+                    context.report({
+                        node,
+                        message: "Redundant double negation.",
+                        fix: fixer => fixer.replaceText(parent, sourceCode.getText(node.argument))
+                    });
                 }
             },
             CallExpression(node) {
@@ -81,7 +88,11 @@ module.exports = {
                 }
 
                 if (isInBooleanContext(node, parent)) {
-                    context.report(node, "Redundant Boolean call.");
+                    context.report({
+                        node,
+                        message: "Redundant Boolean call.",
+                        fix: fixer => fixer.replaceText(node, sourceCode.getText(node.arguments[0]))
+                    });
                 }
             }
         };

diff --git a/tests/lib/rules/no-extra-boolean-cast.js b/tests/lib/rules/no-extra-boolean-cast.js
@@ -37,97 +37,111 @@ ruleTester.run("no-extra-boolean-cast", rule, {
     invalid: [
         {
             code: "if (!!foo) {}",
+            output: "if (foo) {}",
             errors: [{
                 message: "Redundant double negation.",
                 type: "UnaryExpression"
             }]
         },
         {
             code: "do {} while (!!foo)",
+            output: "do {} while (foo)",
             errors: [{
                 message: "Redundant double negation.",
                 type: "UnaryExpression"
             }]
         },
         {
             code: "while (!!foo) {}",
+            output: "while (foo) {}",
             errors: [{
                 message: "Redundant double negation.",
                 type: "UnaryExpression"
             }]
         },
         {
             code: "!!foo ? bar : baz",
+            output: "foo ? bar : baz",
             errors: [{
                 message: "Redundant double negation.",
                 type: "UnaryExpression"
             }]
         },
         {
             code: "for (; !!foo;) {}",
+            output: "for (; foo;) {}",
             errors: [{
                 message: "Redundant double negation.",
                 type: "UnaryExpression"
             }]
         },
         {
             code: "!!!foo",
+            output: "!foo",
             errors: [{
                 message: "Redundant double negation.",
                 type: "UnaryExpression"
             }]
         },
         {
             code: "Boolean(!!foo)",
+            output: "Boolean(foo)",
             errors: [{
                 message: "Redundant double negation.",
                 type: "UnaryExpression"
             }]
         },
         {
             code: "new Boolean(!!foo)",
+            output: "new Boolean(foo)",
             errors: [{
                 message: "Redundant double negation.",
                 type: "UnaryExpression"
             }]
         },
         {
             code: "if (Boolean(foo)) {}",
+            output: "if (foo) {}",
             errors: [{
                 message: "Redundant Boolean call.",
                 type: "CallExpression"
             }]
         },
         {
             code: "do {} while (Boolean(foo))",
+            output: "do {} while (foo)",
             errors: [{
                 message: "Redundant Boolean call.",
                 type: "CallExpression"
             }]
         },
         {
             code: "while (Boolean(foo)) {}",
+            output: "while (foo) {}",
             errors: [{
                 message: "Redundant Boolean call.",
                 type: "CallExpression"
             }]
         },
         {
             code: "Boolean(foo) ? bar : baz",
+            output: "foo ? bar : baz",
             errors: [{
                 message: "Redundant Boolean call.",
                 type: "CallExpression"
             }]
         },
         {
             code: "for (; Boolean(foo);) {}",
+            output: "for (; foo;) {}",
             errors: [{
                 message: "Redundant Boolean call.",
                 type: "CallExpression"
             }]
         },
         {
             code: "!Boolean(foo)",
+            output: "!foo",
             errors: [{
                 message: "Redundant Boolean call.",
                 type: "CallExpression"