Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: add fixer for no-extra-boolean-cast #7387

Merged
merged 1 commit into from
Nov 1, 2016

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[x] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

This adds a fixer for no-extra-boolean-cast.

if (!!foo);
if (Boolean(bar));
Boolean(!!baz);

// gets fixed to:

if (foo);
if (bar);
Boolean(baz);

Is there anything you'd like reviewers to focus on?

We should double-check that removing parens (e.g. Boolean(bar) --> bar) cannot cause a syntax error.

@not-an-aardvark not-an-aardvark added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Oct 18, 2016
@not-an-aardvark not-an-aardvark self-assigned this Oct 18, 2016
@mention-bot
Copy link

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vitorbal, @btmills and @Met48 to be potential reviewers.

@eslintbot
Copy link

LGTM

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@not-an-aardvark
Copy link
Member Author

I think the "check the status of your PR" page is broken with the new CLA; it just displays the CLA again rather than the status of the PR.

@ilyavolodin
Copy link
Member

@not-an-aardvark You should've gotten an email yesterday, but we all need to re-sign CLA due to change with jQuery Foundation -> Linux Foundation

Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion enhancement This change enhances an existing feature of ESLint and removed enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Oct 30, 2016
@nzakas nzakas removed the CLA: Valid label Oct 31, 2016
@not-an-aardvark not-an-aardvark merged commit 36338f0 into master Nov 1, 2016
@not-an-aardvark not-an-aardvark deleted the no-extra-boolean-cast-fixer branch November 1, 2016 06:24
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants