Merge pull request #4836 from eslint/issue4808

Update: Add default limit to `complexity` (fixes #4808)
eslint · Dec 31, 2015 · 994c8ee · 994c8ee
2 parents fd18d4e + 1288ba4
commit 994c8ee
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/docs/rules/complexity.md b/docs/rules/complexity.md
@@ -16,7 +16,7 @@ function a(x) {
 
 ## Rule Details
 
-This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold.
+This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is `20`).
 
 The following patterns are considered problems:
 

diff --git a/lib/rules/complexity.js b/lib/rules/complexity.js
@@ -12,7 +12,7 @@
 
 module.exports = function(context) {
 
-    var THRESHOLD = context.options[0];
+    var THRESHOLD = (typeof context.options[0] !== "undefined") ? context.options[0] : 20;
 
     //--------------------------------------------------------------------------
     // Helpers

diff --git a/tests/lib/rules/complexity.js b/tests/lib/rules/complexity.js
@@ -20,7 +20,8 @@ var rule = require("../../../lib/rules/complexity"),
 var ruleTester = new RuleTester();
 ruleTester.run("complexity", rule, {
     valid: [
-        { code: "function a(x) {}", options: [1] },
+        { code: "function a(x) {}" },
+        { code: "function b(x) {}", options: [1] },
         { code: "function a(x) {if (true) {return x;}}", options: [2] },
         { code: "function a(x) {if (true) {return x;} else {return x+1;}}", options: [2] },
         { code: "function a(x) {if (true) {return x;} else if (false) {return x+1;} else {return 4;}}", options: [3] },