Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance 'no-tabs' rule: New option to only disallow non-indenting tabs #10256

Closed
fabio-silva opened this issue Apr 23, 2018 · 6 comments

Comments

@fabio-silva
Copy link

commented Apr 23, 2018

What rule do you want to change?
no-tabs

Does this change cause the rule to produce more or fewer warnings?
Fewer, as indenting tabs will be allowed.

How will the change be implemented? (New option, new default behavior, etc.)?
New option.

Please provide some example code that this change will affect:

    var name =     'Foo'; //We should get a warning for the tab in between, not for the initial one

What does the rule currently do for this code?
A warning because there are tabs for indentation purposes (in the beginning) and for non-necessarily-indentation purposes (after the assignment)

What will the rule do after it's changed?
Allows indentation tabs using a proper option, but not non-indenting tabs. This could be something like allow-indenting.

@eslint eslint bot added the triage label Apr 23, 2018

@platinumazure platinumazure self-assigned this Apr 23, 2018

@platinumazure

This comment has been minimized.

Copy link
Member

commented Apr 23, 2018

I'll champion this.

@platinumazure platinumazure changed the title Enhance 'no-tabs' rule: only disallow non-indenting tabs Enhance 'no-tabs' rule: New option to only disallow non-indenting tabs Apr 23, 2018

@platinumazure

This comment has been minimized.

Copy link
Member

commented Apr 23, 2018

@fabio-silva Thanks for creating this!

Hope it's okay that I tweaked the title a bit-- just wanted to avoid any team member seeing the title in the issue list and thinking this was about making a breaking change to the rule.

@fabio-silva

This comment has been minimized.

Copy link
Author

commented Apr 23, 2018

@platinumazure Yep, that's totally fine!

@not-an-aardvark

This comment has been minimized.

Copy link
Member

commented Jul 22, 2018

@eslint/eslint-team Anyone else in favor of this proposal? This issue only needs one more 👍 to accept it, otherwise it's probably time to close it.

@kaicataldo

This comment has been minimized.

Copy link
Member

commented Jul 23, 2018

This has now been accepted.

@kaicataldo kaicataldo added accepted and removed evaluating labels Jul 23, 2018

@platinumazure

This comment has been minimized.

Copy link
Member

commented Oct 5, 2018

Working on this.

platinumazure added a commit that referenced this issue Oct 5, 2018

@eslint eslint bot locked and limited conversation to collaborators Apr 11, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.