Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comma-dangle enable functions: "never" by default #11502

Closed
aladdin-add opened this issue Mar 13, 2019 · 1 comment
Closed

comma-dangle enable functions: "never" by default #11502

aladdin-add opened this issue Mar 13, 2019 · 1 comment

Comments

@aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Mar 13, 2019

What rule do you want to change?
comma-dangle
Does this change cause the rule to produce more or fewer warnings?
more
How will the change be implemented? (New option, new default behavior, etc.)?
default behavior: rule option functions: "never"
Please provide some example code that this change will affect:

foo(0, 1,); // no error
foo(0, 1); // no error

What does the rule currently do for this code?
no error reported.

What will the rule do after it's changed?

foo(0, 1,); // report an error
foo(0, 1); // no error

Are you willing to submit a pull request to implement this change?
yes.

@aladdin-add aladdin-add changed the title comma-dangle enable functions: false by default comma-dangle enable functions: "never" by default Mar 13, 2019
@aladdin-add aladdin-add self-assigned this Mar 13, 2019
@not-an-aardvark not-an-aardvark added this to Needs discussion in v6.0.0 Mar 14, 2019
@ilyavolodin ilyavolodin moved this from Needs discussion to Accepted, ready to implement in v6.0.0 Mar 14, 2019
@not-an-aardvark
Copy link
Member

@not-an-aardvark not-an-aardvark commented Mar 15, 2019

This proposal was accepted in yesterday's TSC meeting.

aladdin-add added a commit to aladdin-add/eslint that referenced this issue Mar 17, 2019
aladdin-add added a commit to aladdin-add/eslint that referenced this issue Mar 17, 2019
@not-an-aardvark not-an-aardvark moved this from Accepted, ready to implement to Implemented, pending review in v6.0.0 Mar 18, 2019
aladdin-add added a commit to aladdin-add/eslint that referenced this issue Mar 19, 2019
@mysticatea mysticatea moved this from Implemented, pending review to Ready to merge in v6.0.0 Mar 28, 2019
v6.0.0 automation moved this from Ready to merge to Done Apr 4, 2019
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
v6.0.0
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants