Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comma-dangle enable functions: "never" by default #11502

Closed
aladdin-add opened this issue Mar 13, 2019 · 1 comment · Fixed by #11519
Closed

comma-dangle enable functions: "never" by default #11502

aladdin-add opened this issue Mar 13, 2019 · 1 comment · Fixed by #11519
Assignees
@aladdin-add
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
v6.0.0

Comments

@aladdin-add
Copy link
Member

aladdin-add commented Mar 13, 2019 •
edited

What rule do you want to change?
comma-dangle
Does this change cause the rule to produce more or fewer warnings?
more
How will the change be implemented? (New option, new default behavior, etc.)?
default behavior: rule option functions: "never"
Please provide some example code that this change will affect:

foo(0, 1,); // no error
foo(0, 1); // no error

What does the rule currently do for this code?
no error reported.

What will the rule do after it's changed?

foo(0, 1,); // report an error
foo(0, 1); // no error

Are you willing to submit a pull request to implement this change?
yes.
@aladdin-add aladdin-add added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules breaking This change is backwards-incompatible evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Mar 13, 2019
@aladdin-add aladdin-add changed the title comma-dangle enable functions: false by default comma-dangle enable functions: "never" by default Mar 13, 2019
@aladdin-add aladdin-add self-assigned this Mar 13, 2019
@not-an-aardvark not-an-aardvark added this to Needs discussion in v6.0.0 Mar 14, 2019
@ilyavolodin ilyavolodin moved this from Needs discussion to Accepted, ready to implement in v6.0.0 Mar 14, 2019
@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Mar 15, 2019
@not-an-aardvark
Copy link
Member

This proposal was accepted in yesterday's TSC meeting.

aladdin-add added a commit to aladdin-add/eslint that referenced this issue Mar 17, 2019
@aladdin-add
Breaking: comma-dangle enable functions: "never" by default (fixes es…
111fc9d 
…lint#11502)
@aladdin-add aladdin-add mentioned this issue Mar 17, 2019
Merged
aladdin-add added a commit to aladdin-add/eslint that referenced this issue Mar 17, 2019
@aladdin-add
Breaking: comma-dangle enable functions: "never" (fixes eslint#11502)
e8a027e
@not-an-aardvark not-an-aardvark moved this from Accepted, ready to implement to Implemented, pending review in v6.0.0 Mar 18, 2019
aladdin-add added a commit to aladdin-add/eslint that referenced this issue Mar 19, 2019
@aladdin-add
Breaking: comma-dangle enable functions: "never" (fixes eslint#11502)
0577466
@mysticatea mysticatea moved this from Implemented, pending review to Ready to merge in v6.0.0 Mar 28, 2019
v6.0.0 automation moved this from Ready to merge to Done Apr 4, 2019
not-an-aardvark pushed a commit that referenced this issue Apr 4, 2019
@aladdin-add @not-an-aardvark
Breaking: comma-dangle enable functions: "never" (fixes #11502) (#11519)
4e7cdca
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Oct 2, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aladdin-add aladdin-add

Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
No open projects
v6.0.0
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Breaking: comma-dangle enable functions: "never" (fixes #11502) aladdin-add/eslint
2 participants
@not-an-aardvark @aladdin-add