Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vars-on-top documentation is lying #1234

Closed
lo1tuma opened this issue Sep 9, 2014 · 2 comments · Fixed by #1237
Closed

vars-on-top documentation is lying #1234

lo1tuma opened this issue Sep 9, 2014 · 2 comments · Fixed by #1237
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation

Comments

@lo1tuma
Copy link
Member

lo1tuma commented Sep 9, 2014

The documentation of the vars-on-top rule says that it only requires var-statements to be on the top of functions but it also warns if a var-statement is not on the top of the global scope.
michaelficarra added a commit to michaelficarra/eslint that referenced this issue Sep 9, 2014
@michaelficarra
Docs: fix up vars-on-top documentation (fixes eslint#1234)
2447b69
@michaelficarra michaelficarra mentioned this issue Sep 9, 2014
Merged
@nzakas nzakas added documentation Relates to ESLint's documentation bug ESLint is working incorrectly labels Sep 9, 2014
@nzakas
Copy link
Member

nzakas commented Sep 9, 2014

Yeah, that was just changed.

nzakas added a commit that referenced this issue Sep 9, 2014
@nzakas
Merge pull request #1237 from michaelficarra/GH-1234
0276787 
Docs: fix up vars-on-top documentation (fixes #1234)
@nzakas nzakas reopened this Sep 9, 2014
@nzakas
Copy link
Member

nzakas commented Sep 9, 2014

The title of the page and the short description on the rules index is still incorrect.

lo1tuma added a commit to lo1tuma/eslint that referenced this issue Sep 10, 2014
@lo1tuma
Docs: fix vars-on-top documentation (fixes eslint#1234).
5978fdf
@nzakas nzakas closed this as completed in 3d0c9b7 Sep 10, 2014
nzakas added a commit that referenced this issue Sep 10, 2014
@nzakas
Merge pull request #1243 from lo1tuma/fix-vars-on-top-documentation
41f59f4 
Docs: fix vars-on-top documentation (fixes #1234).
fczuardi added a commit to fczuardi/eslint that referenced this issue Mar 7, 2015
@fczuardi
Fix: remove typo that caused a crash (fixes eslint#1234)
1c40975
fczuardi added a commit to fczuardi/eslint that referenced this issue Mar 8, 2015
@fczuardi
# This is a combination of 2 commits.
798ad79 
# The first commit's message is:

Fix: remove typo that caused a crash (fixes eslint#1234)

# This is the 2nd commit message:

choose ecmaVersion 6 when ecmaFeatures.modules is true
@thechriswalker thechriswalker mentioned this issue Jun 26, 2015
Merged
This was referenced Aug 20, 2015
Merged
Merged
@kentcdodds kentcdodds mentioned this issue Aug 26, 2015
Merged
@platinumazure platinumazure mentioned this issue Dec 2, 2015
Closed
TheIronDev added a commit to TheIronDev/eslint that referenced this issue May 14, 2016
@TheIronDev
Fix: Null check no-extra-parens (Issue eslint#6161)
9a29c33 
Simple fix to one of the new issues. If a node is falsy, then it
definitely will NOT contain an assignment.

Updating commit msg to include eslint#6161

Maybe this will work?
* (fixes eslint#1234)
ljharb added a commit to ljharb/eslint that referenced this issue Aug 4, 2016
@ljharb
Update: improve error message in no-control-regex (fixes eslint#1234)
781d93d
@nzakas nzakas mentioned this issue Aug 30, 2016
Closed
edmorley added a commit to edmorley/eslint that referenced this issue Apr 27, 2017
@edmorley
Chore: Verify array length in --ext tests (refs eslint#1234)
342a333 
Previously the array could have contained more elements than expected.
@not-an-aardvark not-an-aardvark mentioned this issue May 21, 2017
Closed
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sawtaytoes added a commit to Sawtaytoes/eslint that referenced this issue Feb 28, 2020
@Sawtaytoes
Update: Adds ConditionalExpression option to indent rule (fixes eslin…
30a1533 
…t#1234)

This adds the `ConditionalExpression` option to the `indent` rule which allows controlling the indent value of `?` and `:` where they were previously hardcoded to `1`.

Default behavior is unchanged.
Sawtaytoes added a commit to Sawtaytoes/eslint that referenced this issue Mar 2, 2020
@Sawtaytoes
Update: Adds ConditionalExpression option to indent rule (fixes eslin…
764e4f9 
…t#1234)

This adds the `ConditionalExpression` option to the `indent` rule which allows controlling the indent value of `?` and `:` where they were previously hardcoded to `1`.

Default behavior is unchanged.
Sawtaytoes added a commit to Sawtaytoes/eslint that referenced this issue Mar 3, 2020
@Sawtaytoes
Update: Adds ConditionalExpression option to indent rule (fixes eslin…
60a78e2 
…t#1234)

This adds the `ConditionalExpression` option to the `indent` rule which allows controlling the indent value of `?` and `:` where they were previously hardcoded to `1`.

Default behavior is unchanged.
Sawtaytoes added a commit to Sawtaytoes/eslint that referenced this issue Mar 5, 2020
@Sawtaytoes
Update: Adds ConditionalExpression option to indent rule (fixes eslin…
4ec9601 
…t#1234)

This adds the `ConditionalExpression` option to the `indent` rule which allows controlling the indent value of `?` and `:` where they were previously hardcoded to `1`.

Default behavior is unchanged.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Docs: fix up vars-on-top documentation (fixes #1234) michaelficarra/eslint
2 participants
@nzakas @lo1tuma