Allowing inline comments to disable eslint rules. #3471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So first you need to create an issue, explain the problem you have clearly, and then reference that issue from your commit :) |
wbyoung
force-pushed
the
no-inline-except-eslint-disable-line
branch
from
c3f5e42
to
a403b80
Compare
|
@BYK issue created & referenced. |
| @@ -28,8 +28,12 @@ module.exports = function(context) { | |||
| // Also check after the comment | |||
| var postamble = endLine.slice(node.loc.end.column).trim(); | |||
|
|
|||
| // Check that this comment doesn't disable the line | |||
| var disablesLine = startLine.indexOf("eslint-disable-line") >= 0 || | |||
There was a problem hiding this comment.
I think this has to be a bit more specific, otherwise the following would also be ignored:
// someday use eslint-disable-line hereWhat you really want is:
var isDirective = node.value.trim().indexOf("eslint-") === 0;
|
@wbyoung are you still working on this? |
|
I think this is a good way to go for now. |
wbyoung
force-pushed
the
no-inline-except-eslint-disable-line
branch
from
a403b80
to
5ec4e88
Compare
|
@nzakas updated with your suggestion. Sorry for the delay. |
|
@wbyoung Can you update the commit message to have "Update" and not "New". |
wbyoung
force-pushed
the
no-inline-except-eslint-disable-line
branch
from
5ec4e88
to
6179a9d
Compare
wbyoung
force-pushed
the
no-inline-except-eslint-disable-line
branch
from
6179a9d
to
c1d91ea
Compare
|
@gyandeeps done. |
ilyavolodin
added a commit
that referenced
this pull request
Aug 30, 2015
…-line Allowing inline comments to disable eslint rules.
|
Should the docs be updated to mention this? If so I can include in my current cleanup work. |
|
Good catch @IanVS . I think its good to add |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to be able to use inline comments to disable eslint rules, but to disallow any other type of inline comment.
This change allows that configuration.