Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: eslint exit code is 0 when encountering syntax error #1239

Closed
asapach opened this issue Sep 9, 2014 · 3 comments
Closed

cli: eslint exit code is 0 when encountering syntax error #1239

asapach opened this issue Sep 9, 2014 · 3 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly cli Relates to ESLint's command-line interface

Comments

@asapach
Copy link

asapach commented Sep 9, 2014

v0.8.0

Try running eslint on a file that has js syntax errors, e.g.:

{
}}
$ eslint test.js

test.js
  2:2  error  Unexpected token }

✖ 1 problem

Exit code: 0

@nzakas nzakas added bug ESLint is working incorrectly cli Relates to ESLint's command-line interface labels Sep 10, 2014
@nzakas
Copy link
Member

nzakas commented Sep 10, 2014

Confirmed. Looking into this.

@asapach
Copy link
Author

asapach commented Sep 10, 2014

It broke somewhere between 0.6.2 and 0.7.1

@nzakas nzakas closed this as completed in 79df732 Sep 10, 2014
nzakas added a commit that referenced this issue Sep 10, 2014
Fix: Ensure exit code is 1 when there's a syntax error (fixes #1239)
@asapach
Copy link
Author

asapach commented Sep 10, 2014

Thanks! 👍

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly cli Relates to ESLint's command-line interface
Projects
None yet
Development

No branches or pull requests

2 participants