Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint doesn't validate schema for built-in rules #13793

Closed
mdjermanovic opened this issue Oct 26, 2020 · 0 comments
Closed

ESLint doesn't validate schema for built-in rules #13793

mdjermanovic opened this issue Oct 26, 2020 · 0 comments

Comments

@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Oct 26, 2020

Tell us about your environment

  • ESLint Version: v7.12.0
  • Node Version: v6.14.6
  • npm Version: v12.18.4

What parser (default, @babel/eslint-parser, @typescript-eslint/parser, etc.) are you using?

default

Please show your full configuration:

Configuration
module.exports = {
  rules: {
    "accessor-pairs": ["error", { foo: 1 }]
  }
};

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

// anything, the config is important
npx eslint index.js

What did you expect to happen?

Configuration error for accessor-pairs rule.

What actually happened? Please include the actual, raw output from ESLint.

No errors.

Are you willing to submit a pull request to fix this bug?

eslint/eslintrc#14

btmills added a commit that referenced this issue Oct 26, 2020
The bulk of our tests for rule schemas are isolated unit tests of
`ConfigValidator`. This is a single test to be sure we actually run rule
schema validation end-to-end and prevent cases like #13793.

After I run a patch release of `@eslint/eslintrc`, I'll push a second
commit on this branch to bump the dependency version and fix the test.
btmills added a commit that referenced this issue Oct 27, 2020
@btmills btmills closed this in 08f33e8 Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.