no-shadow does not catch shadowing when the shadowing is inside if statement

[grabus]

The following pattern is caught:

let foo = 1;
function bar () {
    let foo = 2;
}

But this is not caught:

let foo = 1;
function bar () {
  if (1) {
    let foo = 2;
  }
}

These are both equivalent examples of shadowing and should thus both be flagged by the rule.

ESLint version: v0.18.0

[gyandeeps]

As of now I dont think this rule takes into consideration blockBindings. Thats why it fails to flag that.

[nzakas]

Can you try upgrading to 0.19.0 and see if there's a difference?

[grabus]

Yep, I've upgraded to 0.19.0 and there is no difference.

[nzakas]

Okay thanks, we'll take a look.

[nzakas]

Working on this.

[nzakas]

Not working on this anymore. Free for someone else to pick up.

[jrvidal]

Working on this.