Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Incorrect method signatures in working-with-rules #3862

Closed
alberto opened this issue Sep 20, 2015 · 2 comments
Closed

Docs: Incorrect method signatures in working-with-rules #3862

alberto opened this issue Sep 20, 2015 · 2 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features documentation Relates to ESLint's documentation

Comments

@alberto
Copy link
Member

alberto commented Sep 20, 2015

The remove and removeRange fixer signatures are wrong. They should be:

  • remove(nodeOrToken) - removes the given node or token
  • removeRange(range) - removes text in the given range
@eslintbot
Copy link

Thanks for the issue! If you're reporting a bug, please be sure to include:

  1. The version of ESLint you are using (run eslint -v)
  2. What you did (the source code and ESLint configuration)
  3. The actual ESLint output complete with numbers
  4. What you expected to happen instead

Requesting a new rule? Please see Proposing a New Rule for instructions.

@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Sep 20, 2015
@IanVS IanVS added bug ESLint is working incorrectly documentation Relates to ESLint's documentation core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Sep 20, 2015
@IanVS
Copy link
Member

IanVS commented Sep 20, 2015

Good catch.

ilyavolodin added a commit that referenced this issue Sep 20, 2015
@ilyavolodin
Merge pull request #3864 from alberto/issue3862
bd9204b 
Docs: Fix method signature on working-with-rules docs (fixes #3862)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features documentation Relates to ESLint's documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alberto @IanVS @eslintbot