Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-implicit-coercion rule does not validate foo+="" #4348

Closed
ipanasenko opened this issue Nov 6, 2015 · 2 comments
Closed

no-implicit-coercion rule does not validate foo+="" #4348

ipanasenko opened this issue Nov 6, 2015 · 2 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules

Comments

@ipanasenko
Copy link
Contributor

Hey, guys

no-implicit-coercion rule doesn't validate following code:

foo += "";

I think it should consider this code as invalid.
@eslintbot
Copy link

Thanks for the issue! If you're reporting a bug, please be sure to include:

  1. The version of ESLint you are using (run eslint -v)
  2. What you did (the source code and ESLint configuration)
  3. The actual ESLint output complete with numbers
  4. What you expected to happen instead

Requesting a new rule? Please see Proposing a New Rule for instructions.

@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Nov 6, 2015
@ipanasenko ipanasenko mentioned this issue Nov 6, 2015
Merged
@ipanasenko
Copy link
Contributor Author

PR: #4349

@nzakas nzakas added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Nov 6, 2015
@nzakas nzakas closed this as completed in 4916dc6 Nov 19, 2015
nzakas added a commit that referenced this issue Nov 19, 2015
@nzakas
Merge pull request #4349 from ipanasenko/issue-4348
cef00c3 
Update: no-implicit-coercion to validate AssignmentExpression (fixes #4348)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nzakas @ipanasenko @eslintbot