New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't pass dot/hidden files on command line #4828
Comments
@radek-holy Thanks for the issue! If you're reporting a bug, please be sure to include:
Requesting a new rule? Please see Proposing a New Rule for instructions. |
Are you asking to include all dot files or just .eslintrc.js? Note you can pass .eslintrc.js directly on the command line already. |
I'm asking to include all dot files. At least optionally. It is related to the feature request #4829 (I'd like to test all the |
Can't you just pass |
Yes, sure, I can. This is just a request for a nice to have feature. I thought that because ESLint started to support JavaScript configs, potentially every user who uses |
@nzakas, sadly seems explicit |
@DarkPark Maybe there's nothing to warn about. |
@DarkPark Could you try to run the same command with |
@michaelficarra, I deliberately made some :) |
v2.3.0 @ilyavolodin,
|
@DarkPark can you rename to |
@nzakas, sure, here it is: eslint --debug ./eslintrc.js
|
Thanks. So this looks like a bug, we should be linting anything passed on the command line. We should fix that. |
@nzakas So if we do What about |
Yes because it was passed on the command line.
No because it wasn't passed on the command line. |
Agree with @michaelficarra |
So, I guess we should also allow doing something like Also, for reference, the current behaviour with hidden files is explicitly covered by our tests here. |
Yup |
ok, one more question (sorry I keep coming at this, I'm trying to understand the reach and implications of this). What about glob patterns? Should |
@radek-holy as a workaround, you can run |
I did a little digging, and I think I figured out what's going on. When you pass in So, while the
I also think it would be safe for us to use the |
@IanVS can you summarize what your proposal is at this point? |
He's proposing to change |
I no longer think it's necessary to include a command line option, since the same can be easily accomplished with a But, if we do this, dotfiles ending with |
Regarding my last statement above, I think this highlights a deeper problem, similar to #5547. Using So to be clear, my proposal is:
|
Sounds good. |
My point number one above should be covered by #5820. After that is merged, I'll work on number two. |
Sorry, I lost track of this. Will work on it shortly. |
I think we should wait on this until #6710 is solved. |
Sorry, you are right maybe it's not needed. I was planning to fix #6710 and then fix this, because I was concerned there could be a performance impact with hidden folders created by tools, but I don't have any numbers. |
Hello,
since JavaScript config files are supported now, can you please consider adding a (at least optional) way to ask
eslint
to lint also hidden/dot files (e.g..eslintrc.js
or.eslintrc.json
with the JSON plugin) if a name to a directory is passed (e.g.eslint .
)?Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: