Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-restricted-properties is in the wrong category #7112

Closed
ljharb opened this issue Sep 10, 2016 · 2 comments · Fixed by #7118
Closed

no-restricted-properties is in the wrong category #7112

ljharb opened this issue Sep 10, 2016 · 2 comments · Fixed by #7118
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation good first issue Good for people who haven't worked on ESLint before help wanted The team would welcome a contribution from the community for this issue

Comments

@ljharb
Copy link
Sponsor Contributor

ljharb commented Sep 10, 2016

https://github.com/eslint/eslint/blob/master/lib/rules/no-restricted-properties.js#L18 is in http://eslint.org/docs/rules/#nodejs-and-commonjs and I'm not sure why - this is a generic rule and has nothing to do with node and commonJS. It seems like "best practices" or "stylistic" is a better category for it?
@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Sep 10, 2016
@kaicataldo kaicataldo added bug ESLint is working incorrectly documentation Relates to ESLint's documentation evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Sep 10, 2016
@kaicataldo
Copy link
Member

I agree! My vote is for "Best Practices":

These rules relate to better ways of doing things to help you avoid problems

@kaicataldo kaicataldo added good first issue Good for people who haven't worked on ESLint before help wanted The team would welcome a contribution from the community for this issue labels Sep 10, 2016
alecharmon pushed a commit to alecharmon/eslint that referenced this issue Sep 11, 2016
Fix: updates category of no-restricted-properties to Best Practices (f…
24720a7 
…ixes eslint#7112)
alecharmon pushed a commit to alecharmon/eslint that referenced this issue Sep 11, 2016
Fix: updates category of no-restricted-properties (fixes eslint#7112)
f97ef54
@alecharmon alecharmon mentioned this issue Sep 11, 2016
Merged
3 tasks
@kaicataldo kaicataldo removed the bug ESLint is working incorrectly label Sep 11, 2016
@kaicataldo
Copy link
Member

Removing the bug label so it's clear this is a docs change. Sorry for the confusion!

alecharmon pushed a commit to alecharmon/eslint that referenced this issue Sep 12, 2016
Fix: updates category of no-restricted-properties (fixes eslint#7112)
54fd108
vitorbal pushed a commit that referenced this issue Sep 12, 2016
@vitorbal
Docs: updates category of no-restricted-properties (fixes #7112) (#7118)
e462e47
ljharb added a commit to airbnb/javascript that referenced this issue Sep 12, 2016
@ljharb
[eslint config] [base] [patch] fix category of `no-restricted-propert…
e9141f4 
…ies`

Per eslint/eslint#7112 / eslint/eslint#7118
ljharb pushed a commit to ljharb/eslint that referenced this issue Sep 13, 2016
@ljharb
Docs: updates category of no-restricted-properties (fixes eslint#7112) (
3c33edb 
eslint#7118)
hibearpanda pushed a commit to 15Prospects/javascript that referenced this issue Jan 22, 2017
@ljharb @hibearpanda
[eslint config] [base] [patch] fix category of `no-restricted-propert…
e5c0dba 
…ies`

Per eslint/eslint#7112 / eslint/eslint#7118
jaylaw81 pushed a commit to appirio-digital/ads-best-practices that referenced this issue Sep 19, 2017
@ljharb @jaylaw81
[eslint config] [base] [patch] fix category of `no-restricted-propert…
1c35004 
…ies`

Per eslint/eslint#7112 / eslint/eslint#7118
sensiblegame added a commit to sensiblegame/React-BNB that referenced this issue Oct 23, 2017
@sensiblegame
[eslint config] [base] [patch] fix category of `no-restricted-propert…
4b0d3ff 
…ies`

Per eslint/eslint#7112 / eslint/eslint#7118
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation good first issue Good for people who haven't worked on ESLint before help wanted The team would welcome a contribution from the community for this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: updates category of no-restricted-properties to Best Practices (… alecharmon/eslint
3 participants
@ljharb @kaicataldo @eslintbot